Issue 521005: Mac: Double-clicking tabs in the task manager should focus that tab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 521005: Mac: Double-clicking tabs in the task manager should focus that tab. (Closed)

Created:
11 years ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Avi (use Gerrit), Jens Alfke

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Mac: Double-clicking tabs in the task manager should focus that tab. BUG=13156 TEST=Hook up task manager. Open it, double-click tabs. They should become active. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35225

Patch Set 1 #

Total comments: 3

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
	M	chrome/browser/cocoa/task_manager_mac.h	View		1 chunk	+3 lines, -0 lines	1 comment	Download
	M	chrome/browser/cocoa/task_manager_mac.mm	View		2 chunks	+10 lines, -3 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jens Alfke

http://codereview.chromium.org/521005/diff/1/2 File chrome/browser/cocoa/task_manager_mac.h (right): http://codereview.chromium.org/521005/diff/1/2#newcode35 chrome/browser/cocoa/task_manager_mac.h:35: - (void)selectDoubleClickedTab:(id)sender; Technically this should be an (IBAction) even ...

11 years ago (2009-12-23 19:38:48 UTC) #2

Nico

11 years ago (2009-12-23 19:45:14 UTC) #3

http://codereview.chromium.org/521005/diff/1/3
File chrome/browser/cocoa/task_manager_mac.mm (right):

http://codereview.chromium.org/521005/diff/1/3#newcode78
chrome/browser/cocoa/task_manager_mac.mm:78: [tableView_
setDoubleAction:@selector(selectDoubleClickedTab:)];
On 2009/12/23 19:38:48, Jens Alfke wrote:
> I would set the tableView_'s target too for safety's sake.

 If i stick to what the documentation says ("For the method to have any effect,
the receiver’s action and target must be set to the class in which the selector
is declared"), then i also need to set an action in addtion to a target, and
adding an empty method for that seems silly to me.

(Not listening to the documentation seems silly to me too though, so i'll
probably add that both when i touch the file the next time, which is soon.)

Expand Messages | Collapse Messages