Mac: Double-clicking tabs in the task manager should focus that tab.

chrome/browser/cocoa/task_manager_mac.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/cocoa/task_manager_mac.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "app/l10n_util_mac.h"
 #include "base/mac_util.h"
 #include "base/sys_string_conversions.h"
 #include "grit/generated_resources.h"
 
 // TODO(thakis): Autoremember window size/pos (and selected columns?)
 // TODO(thakis): Column sort comparator
-// TODO(thakis): Double-clicking a tab should activate that tab
 // TODO(thakis): Clicking column header doesn't sort
-// TODO(thakis): Double-clicking a row seems to do something on win/linux
 // TODO(thakis): On window close, stop updating
 // TODO(thakis): Favicons in rows
 // TODO(thakis): Default sort column
-// TODO(thakis): Metrics are all wrong (some fixed when about:memory lands?)
+// TODO(thakis): Metrics for all processes except browser process are missing.
 
 @interface TaskManagerWindowController (Private)
 - (void)addColumnWithId:(int)columnId visible:(BOOL)isVisible;
 - (void)setUpTableColumns;
 - (void)setUpTableHeaderContextMenu;
 - (void)toggleColumn:(id)sender;
 - (void)adjustEndProcessButton;
 @end
 
 ////////////////////////////////////////////////////////////////////////////////
@@ skipping 24 matching lines @@
 
 - (IBAction)killSelectedProcesses:(id)sender {
   NSIndexSet* selection = [tableView_ selectedRowIndexes];
   for (NSUInteger i = [selection lastIndex];
        i != NSNotFound;
        i = [selection indexLessThanIndex:i]) {
     taskManager_->KillProcess(i);
   }
 }
 
+- (void)selectDoubleClickedTab:(id)sender {
+  NSInteger row = [tableView_ clickedRow];
+  if (row < 0)
+    return;  // Happens e.g. if the table header is double-clicked.
+  taskManager_->ActivateProcess(row);
+}
+
 - (void)awakeFromNib {
   [self setUpTableColumns];
   [self setUpTableHeaderContextMenu];
   [self adjustEndProcessButton];
+
+  [tableView_ setDoubleAction:@selector(selectDoubleClickedTab:)];

[Jens Alfke, 2009/12/23 19:38:48]

I would set the tableView_'s target too for safety's sake.

[Nico, 2009/12/23 19:45:14]

 If i stick to what the documentation says ("For the method to have any effect,
the receiver’s action and target must be set to the class in which the selector
is declared"), then i also need to set an action in addtion to a target, and
adding an empty method for that seems silly to me.

(Not listening to the documentation seems silly to me too though, so i'll
probably add that both when i touch the file the next time, which is soon.)

 }
 
 // Adds a column which has the given string id as title. |isVisible| specifies
 // if the column is initially visible.
 - (void)addColumnWithId:(int)columnId visible:(BOOL)isVisible {
   scoped_nsobject<NSTableColumn> column([[NSTableColumn alloc]
       initWithIdentifier:[NSNumber numberWithInt:columnId]]);
 
   NSTextAlignment textAlignment = columnId == IDS_TASK_MANAGER_PAGE_COLUMN ?
       NSLeftTextAlignment : NSRightTextAlignment;
@@ skipping 209 matching lines @@
 void TaskManagerMac::Show() {
   if (instance_) {
     // If there's a Task manager window open already, just activate it.
     [[instance_->window_controller_ window]
         makeKeyAndOrderFront:instance_->window_controller_];
   } else {
     instance_ = new TaskManagerMac;
     instance_->model_->StartUpdating();
   }
 }