Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 52093012: Add a .clang-format file to give us local control over Chromium style. (Closed)

Created:
7 years, 1 month ago by Jeffrey Yasskin
Modified:
3 years, 7 months ago
Reviewers:
pakistan.raja23, Nico, Ben Goodger (Google), Pakistan.raja23, lucky508523
CC:
abarth-chromium, chromium-reviews, djasper_google.com, eseidel
Visibility:
Public.

Description

Add a .clang-format file to give us local control over Chromium style. This also makes editor integration somewhat easier by letting editors pass just "-style=file -assume-filename=<filename>" to clang-format instead of needing to guess the desired style based on the path. We could name this file _clang-format instead, if that's easier for Windows. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232271

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
A .clang-format View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 15 (3 generated)
Jeffrey Yasskin
Defining the style here will let us change it (within existing options) without involving a ...
7 years, 1 month ago (2013-10-31 19:53:49 UTC) #1
Ben Goodger (Google)
7 years, 1 month ago (2013-10-31 20:04:50 UTC) #2
Nico
Ben: Given that I sent the same CL to you 9 weeks ago ( https://codereview.chromium.org/23877002/ ...
7 years, 1 month ago (2013-10-31 20:09:32 UTC) #3
Jeffrey Yasskin
On 2013/10/31 20:09:32, Nico wrote: > Ben: Given that I sent the same CL to ...
7 years, 1 month ago (2013-10-31 20:14:20 UTC) #4
Peter Kasting
Removing myself, I have no comment
7 years, 1 month ago (2013-10-31 20:15:39 UTC) #5
Ben Goodger (Google)
Sorry! If I don't respond to a CL it's possible I just archived it accidentally. ...
7 years, 1 month ago (2013-10-31 20:48:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/52093012/1
7 years, 1 month ago (2013-10-31 21:12:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/52093012/1
7 years, 1 month ago (2013-10-31 23:40:45 UTC) #8
commit-bot: I haz the power
Change committed as 232271
7 years, 1 month ago (2013-11-01 01:53:42 UTC) #9
lucky508523
lgtm
3 years, 11 months ago (2016-12-28 20:47:31 UTC) #11
Pakistan.raja23
lgtm
3 years, 7 months ago (2017-05-12 22:27:51 UTC) #13
Pakistan.raja23
3 years, 7 months ago (2017-05-17 19:43:37 UTC) #15
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698