Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 32673005: Add a .clang-format file to give us local control over Blink style. (Closed)

Created:
7 years, 2 months ago by Jeffrey Yasskin
Modified:
7 years, 2 months ago
Reviewers:
djasper, eseidel
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@pinned
Visibility:
Public.

Description

Add a .clang-format file to give us local control over Blink style. This also makes editor integration somewhat easier by letting editors pass just "-style=file -assume-filename=<filename>" to clang-format instead of needing to guess the desired style based on the path. We could name this file _clang-format instead, if that's easier for Windows. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160157

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
.clang-format View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
Jeffrey Yasskin
Defining the style here will let us change it (within existing options) without involving a ...
7 years, 2 months ago (2013-10-21 21:02:11 UTC) #1
eseidel
lgtm from a blink perspective. You're certainly welcome to add a .file to the top ...
7 years, 2 months ago (2013-10-21 21:33:13 UTC) #2
eseidel
You could also add yourself as an OWNER of this file, assuming you plan to ...
7 years, 2 months ago (2013-10-21 21:33:38 UTC) #3
Jeffrey Yasskin
On 2013/10/21 21:33:38, eseidel wrote: > You could also add yourself as an OWNER of ...
7 years, 2 months ago (2013-10-21 21:37:53 UTC) #4
eseidel
So the immediate effect of this is that you no longer have to specify the ...
7 years, 2 months ago (2013-10-21 21:38:47 UTC) #5
Jeffrey Yasskin
On 2013/10/21 21:38:47, eseidel wrote: > So the immediate effect of this is that you ...
7 years, 2 months ago (2013-10-21 21:49:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/32673005/1
7 years, 2 months ago (2013-10-21 22:32:01 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-22 08:55:36 UTC) #8
Message was sent while issue was closed.
Change committed as 160157

Powered by Google App Engine
This is Rietveld 408576698