Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issue 520723002: Stop inlining StringBuffer<CharType>::shrink(). (Closed)

Created:
6 years, 3 months ago by Daniel Bratell
Modified:
6 years, 3 months ago
CC:
aandrey+blink_chromium.org, abarth-chromium, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Stop inlining StringBuffer<CharType>::shrink(). Minor cleanup as part of looking at overly aggressive inlining. The default for all code should be that no code is force-inlined unless it is critical for some other reason. This is a prerequisite for http://codereview.chromium.org/390003003/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181193

Patch Set 1 : Unittests #

Patch Set 2 : StringBuffer::shrink(). Warnings signed 0 compared to unsigned length. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -7 lines) Patch
M Source/wtf/text/StringBuffer.h View 2 chunks +10 lines, -7 lines 0 comments Download
A Source/wtf/text/StringBufferTest.cpp View 1 1 chunk +46 lines, -0 lines 0 comments Download
M Source/wtf/wtf.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
Daniel Bratell
Patchset #1 (id:1) has been deleted
6 years, 3 months ago (2014-08-29 14:37:46 UTC) #1
Daniel Bratell
bratell@opera.com changed reviewers: + esprehn@chromium.org
6 years, 3 months ago (2014-08-29 14:39:16 UTC) #2
Daniel Bratell
esprehn, here is the extractable wtf part from https://codereview.chromium.org/390003003/ - Can you please take a ...
6 years, 3 months ago (2014-08-29 14:39:16 UTC) #3
esprehn
lgtm
6 years, 3 months ago (2014-08-29 20:08:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bratell@opera.com/520723002/40001
6 years, 3 months ago (2014-09-01 08:18:47 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 3 months ago (2014-09-01 09:02:59 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/14124)
6 years, 3 months ago (2014-09-01 09:06:56 UTC) #9
Daniel Bratell
jochen, can you please take a look at this small change in wtf?
6 years, 3 months ago (2014-09-01 09:43:07 UTC) #11
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-01 13:19:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bratell@opera.com/520723002/40001
6 years, 3 months ago (2014-09-01 13:38:51 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-01 13:43:38 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as 181193

Powered by Google App Engine
This is Rietveld 408576698