Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 390003003: Shrink canonicalizedTitle a bit. (Closed)

Created:
6 years, 5 months ago by Daniel Bratell
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Shrink canonicalizedTitle a bit. Noticed that it was (in content_shell x64 for Linux) 421 and 425 bytes which seemed excessive. Just rewrote it a bit to do less work for the same result. gcc (not even going to guess why createQualifiedName changed): --------------------------------------------------------------------------------------------------------------------- -635 - Source: /home/bratell/src/chromium/src/third_party/WebKit/Source/core/dom/Document.cpp - (gained 8, lost 643) --------------------------------------------------------------------------------------------------------------------- Grown symbols: +8: WebCore::Document::didChangeVisibilityState() type=t, (was 299 bytes, now 307 bytes) Shrunk symbols: -64: WebCore::createQualifiedName(WTF::AtomicString const&, WTF::AtomicString const&, WebCore::ExceptionState&) type=t, (was 1112 bytes, now 1048 bytes) -579: WebCore::Document::updateTitle(WTF::String const&) type=t, (was 1541 bytes, now 962 bytes) clang: Shrunk symbols: -241: WebCore::Document::updateTitle(WTF::String const&) type=t, (was 1124 bytes, now 883 bytes) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181746

Patch Set 1 : Shrink canonicalizedTitle #

Patch Set 2 : Smaller canonicalizedTitle #

Patch Set 3 : Shrink canonicalizedTitle and clean up StringBuffer. #

Patch Set 4 : Rebased to newer origin/master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -47 lines) Patch
M Source/core/dom/Document.cpp View 1 2 3 1 chunk +13 lines, -34 lines 0 comments Download
M Source/wtf/text/StringBuffer.h View 1 2 3 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
Daniel Bratell
esprehn, can you take a look at this micro cleanup patch? Basically a followup of ...
6 years, 5 months ago (2014-07-21 12:12:47 UTC) #1
Daniel Bratell
Ah, I changed StringBuffer as well (removed an unused method and un-force-inlined shrink) so an ...
6 years, 5 months ago (2014-07-21 12:14:10 UTC) #2
esprehn
Can we do this in two changes? First change WTF and then change caller? Also ...
6 years, 4 months ago (2014-08-01 14:13:25 UTC) #3
Daniel Bratell
On 2014/08/01 14:13:25, esprehn wrote: > Can we do this in two changes? First change ...
6 years, 4 months ago (2014-08-01 14:24:24 UTC) #4
esprehn
How goes this?
6 years, 4 months ago (2014-08-19 02:01:07 UTC) #5
Daniel Bratell
On 2014/08/19 02:01:07, esprehn wrote: > How goes this? Looked at it now. Splitting into ...
6 years, 3 months ago (2014-08-29 13:39:32 UTC) #6
Daniel Bratell
On 2014/08/29 13:39:32, Daniel Bratell wrote: > On 2014/08/19 02:01:07, esprehn wrote: > > How ...
6 years, 3 months ago (2014-08-29 14:40:21 UTC) #7
Daniel Bratell
The outlining of shrink has now landed. jochen, can you please take a look at ...
6 years, 3 months ago (2014-09-01 14:59:40 UTC) #9
jochen (gone - plz use gerrit)
wtf/ lgtm
6 years, 3 months ago (2014-09-02 08:21:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bratell@opera.com/390003003/100001
6 years, 3 months ago (2014-09-10 15:48:40 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 16:51:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:100001) as 181746

Powered by Google App Engine
This is Rietveld 408576698