Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 520703002: Fixed flakyness of PolicyTest.FileURLBlacklist. (Closed)

Created:
6 years, 3 months ago by Joao da Silva
Modified:
6 years, 3 months ago
Reviewers:
pastarmovj
CC:
chromium-reviews, dconnelly, Jeffrey Yasskin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixed flakyness of PolicyTest.FileURLBlacklist. The problem was introduced in https://codereview.chromium.org/110643005. The URLBlacklistManager used to build the blacklist in the FILE thread but it's now using the blocking pool; however, FlushBlacklistPolicy wasn't updated to flush the blocking pool instead of the FILE thread. This test (and the URL blacklist tests too) have been flaking now and then on every bot but this race is extremely hard to trigger. DrMemory on Windows was a consistent repro though. BUG=339240 Committed: https://crrev.com/8d2d9254a094cb485874336117c8ca7960296c3d Cr-Commit-Position: refs/heads/master@{#292874}

Patch Set 1 #

Patch Set 2 : Remove DrMemory exclude #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M chrome/browser/policy/policy_browsertest.cc View 4 chunks +9 lines, -4 lines 0 comments Download
M tools/valgrind/gtest_exclude/browser_tests.gtest-drmemory.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Joao da Silva
joaodasilva@chromium.org changed reviewers: + pastarmovj@chromium.org
6 years, 3 months ago (2014-08-29 14:13:58 UTC) #1
Joao da Silva
Julian, PTAL. Daniel, Jeffrey FYI Thanks!
6 years, 3 months ago (2014-08-29 14:13:59 UTC) #2
pastarmovj
lgtm
6 years, 3 months ago (2014-09-01 14:15:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/520703002/20001
6 years, 3 months ago (2014-09-01 14:18:01 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as a0158c3cc58ea93ba3a5de44df7452be5fb981a8
6 years, 3 months ago (2014-09-01 14:42:34 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:16:56 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8d2d9254a094cb485874336117c8ca7960296c3d
Cr-Commit-Position: refs/heads/master@{#292874}

Powered by Google App Engine
This is Rietveld 408576698