Refactored the URLBlacklistManager to avoid chrome/ and content/ dependencies.

Refactored the URLBlacklistManager to avoid chrome/ and content/ dependencies.

This class will be moved into the policy component so that it can be reused
on iOS. This change removes direct dependencies on chrome/ and content/ code
so that it can be subsequently moved into the component.

BUG=271392
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241239

[Joao da Silva, 2013-12-12 15:08:12]

PTAL, thanks!

[Joao da Silva, 2013-12-12 15:50:57]

+Bernhard: please review managed_mode_url_filter.cc

+Elliot: please review profile_io_data.cc

Thanks!

[Elliot Glaysher, 2013-12-12 19:16:55]

https://codereview.chromium.org/110643005/diff/20001/chrome/browser/profiles/...
File chrome/browser/profiles/profile_io_data.cc (right):

https://codereview.chromium.org/110643005/diff/20001/chrome/browser/profiles/...
chrome/browser/profiles/profile_io_data.cc:494: URLFixerUpper::SegmentURL);
Why do you need this cast here? Is it because of there are multiple overloads on
the name SegmentURL?

[Bernhard Bauer, 2013-12-13 00:42:29]

managed_mode/ LGTM, with the same question that Elliot had.

[Joao da Silva, 2013-12-13 11:00:00]

Elliot, please see inline and have another look.

Bartosz, ping :-)

https://codereview.chromium.org/110643005/diff/20001/chrome/browser/profiles/...
File chrome/browser/profiles/profile_io_data.cc (right):

https://codereview.chromium.org/110643005/diff/20001/chrome/browser/profiles/...
chrome/browser/profiles/profile_io_data.cc:494: URLFixerUpper::SegmentURL);
On 2013/12/12 19:16:55, Elliot Glaysher wrote:
> Why do you need this cast here? Is it because of there are multiple overloads
on
> the name SegmentURL?

Yes, otherwise this fails because SegmentURL is ambiguous. If you know of a
better way to fix this then I'm happy to improve it.

(if the overloaded name were in policy/ code I'd happily rename one of the
functions, but in this case I don't think it's worth it)

[Joao da Silva, 2013-12-13 14:40:41]

Julian, can you review the policy bits? (Bartosz OOO)

[Elliot Glaysher, 2013-12-13 18:42:08]

profiles lgtm

[pastarmovj, 2013-12-16 13:27:04]

lgtm

[commit-bot: I haz the power, 2013-12-16 13:54:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/110643005/100001

[commit-bot: I haz the power, 2013-12-16 14:42:55]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-12-16 15:46:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/110643005/100001

[commit-bot: I haz the power, 2013-12-16 17:04:27]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-12-16 18:19:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/110643005/100001

[commit-bot: I haz the power, 2013-12-16 19:06:43]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-12-16 22:52:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/110643005/110001

[commit-bot: I haz the power, 2013-12-17 02:18:08]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-12-17 08:40:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/110643005/110001

[commit-bot: I haz the power, 2013-12-17 09:35:45]

Change committed as 241239