Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 52030: Apply ICU patches for ICU tickets 6175 (ISO-2022 and ... (Closed)

Created:
11 years, 9 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
agl
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Apply ICU patches for ICU tickets 6175 (ISO-2022 and HZ empty segment handling bug) and 5691 (Mulibyte encoding invalid sequence handling bug). The patch for ICU ticket 5691 was back ported before (r4302, crbug.com/2074), but that for 6175 has not been. I was mistaken that Webkit-based browsers are not affected by this issue, but recently I found that Apple had fixed it in their copy of ICU in May 2008 (thanks to Adam). And more importantly, we are affected even though I can't come up with an actual exploit case in a web browser (On the server-side, this can be a real issue) as opposed to a simple alert box coming up. To make applying the patch easier, I consolidated the patches for ICU tickets 5691 and 6175 along with patches for other ICU tickets listed below into a single patch file (uconv.security.patch). We can live without the patches for tickets other than 6175 and 5691, but it makes easier to maintain our copy of ICU with them applied together. As a side-benefit(?), GB-HZ converter that was not fixed in r4302 is also fixed (it does not really matter because we don't support GB-HZ, but just in case ...) http://icu-project.org/trac/ticket/6001 (r22849, 22851) http://icu-project.org/trac/ticket/6002 (r22847, 22850) http://icu-project.org/trac/ticket/6071 (r23041) http://icu-project.org/trac/ticket/6175 (r23571, 23572) http://icu-project.org/trac/ticket/6358 (r24245) http://icu-project.org/trac/ticket/6412 (r24468) http://icu-project.org/trac/ticket/5691 (r24733,24769,24770,24773,24778,24824,24825) TEST= 1. Go to https://bug381412.bugzilla.mozilla.org/attachment.cgi?id=267398 and see a bunch of 'inverse question marks' for U+FFFD. Also, hovering the mouse over 'aaa' should not bring up an alert box. A real layout test will be added later. 2. chrome/fast/encoding/Invalid_multibyte-over-consumption.html BUG=2074, 3823 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12390

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2873 lines, -582 lines) Patch
M third_party/icu38/README.google View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/icu38/public/common/unicode/ucnv.h View 3 chunks +15 lines, -2 lines 0 comments Download
M third_party/icu38/source/common/ucnv.c View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/icu38/source/common/ucnv2022.c View 16 chunks +103 lines, -23 lines 0 comments Download
M third_party/icu38/source/common/ucnv_bld.h View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/icu38/source/common/ucnv_bld.c View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/icu38/source/common/ucnv_ext.h View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/icu38/source/common/ucnv_ext.c View 7 chunks +53 lines, -9 lines 0 comments Download
M third_party/icu38/source/common/ucnv_lmb.c View 3 chunks +10 lines, -11 lines 0 comments Download
M third_party/icu38/source/common/ucnv_set.c View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/icu38/source/common/ucnvhz.c View 11 chunks +134 lines, -99 lines 0 comments Download
M third_party/icu38/source/common/ucnvmbcs.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/icu38/source/common/ucnvmbcs.c View 11 chunks +69 lines, -17 lines 0 comments Download
M third_party/icu38/source/common/uset_imp.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/icu38/source/test/cintltst/ncnvtst.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/icu38/source/test/cintltst/nucnvtst.c View 4 chunks +67 lines, -0 lines 0 comments Download
M third_party/icu38/source/test/intltest/convtest.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/icu38/source/test/intltest/convtest.cpp View 2 chunks +178 lines, -0 lines 0 comments Download
M third_party/icu38/source/test/testdata/Makefile.in View 1 chunk +1 line, -1 line 0 comments Download
M third_party/icu38/source/test/testdata/conversion.txt View 11 chunks +170 lines, -6 lines 0 comments Download
M third_party/icu38/source/test/testdata/testdata.mak View 3 chunks +6 lines, -1 line 0 comments Download
M third_party/icu38/uconv.security.patch View 12 chunks +1990 lines, -404 lines 0 comments Download
A third_party/icu38/uconv.security.header.patch View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jungshik at Google
11 years, 9 months ago (2009-03-24 18:38:52 UTC) #1
agl
11 years, 9 months ago (2009-03-24 18:43:37 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698