Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: third_party/icu38/source/common/ucnv_lmb.c

Issue 52030: Apply ICU patches for ICU tickets 6175 (ISO-2022 and ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/icu38/source/common/ucnv_ext.c ('k') | third_party/icu38/source/common/ucnv_set.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/icu38/source/common/ucnv_lmb.c
===================================================================
--- third_party/icu38/source/common/ucnv_lmb.c (revision 10949)
+++ third_party/icu38/source/common/ucnv_lmb.c (working copy)
@@ -1,6 +1,6 @@
/*
**********************************************************************
-* Copyright (C) 2000-2006, International Business Machines
+* Copyright (C) 2000-2007, International Business Machines
* Corporation and others. All Rights Reserved.
**********************************************************************
* file name: ucnv_lmb.cpp
@@ -536,7 +536,7 @@
NULL,\
NULL,\
_LMBCSSafeClone,\
- _LMBCSGetUnicodeSet\
+ ucnv_getCompleteUnicodeSet\
};\
static const UConverterStaticData _LMBCSStaticData##n={\
sizeof(UConverterStaticData),\
@@ -662,15 +662,14 @@
return &newLMBCS->cnv;
}
-static void
-_LMBCSGetUnicodeSet(const UConverter *cnv,
- const USetAdder *sa,
- UConverterUnicodeSet which,
- UErrorCode *pErrorCode) {
- /* all but U+F6xx, see LMBCS explanation above (search for F6xx) */
- sa->addRange(sa->set, 0, 0xf5ff);
- sa->addRange(sa->set, 0xf700, 0x10ffff);
-}
+/*
+ * There used to be a _LMBCSGetUnicodeSet() function here (up to svn revision 20117)
+ * which added all code points except for U+F6xx
+ * because those cannot be represented in the Unicode group.
+ * However, it turns out that windows-950 has roundtrips for all of U+F6xx
+ * which means that LMBCS can convert all Unicode code points after all.
+ * We now simply use ucnv_getCompleteUnicodeSet().
+ */
/*
Here's the basic helper function that we use when converting from
« no previous file with comments | « third_party/icu38/source/common/ucnv_ext.c ('k') | third_party/icu38/source/common/ucnv_set.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698