Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1578)

Unified Diff: components/cronet/android/java/src/org/chromium/net/AsyncUrlRequestFactory.java

Issue 520093002: Initial declaration of Cronet Async API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/AsyncUrlRequestFactory.java
diff --git a/components/cronet/android/java/src/org/chromium/net/AsyncUrlRequestFactory.java b/components/cronet/android/java/src/org/chromium/net/AsyncUrlRequestFactory.java
new file mode 100644
index 0000000000000000000000000000000000000000..9e234df5e6551d278571907872038c7f573530b9
--- /dev/null
+++ b/components/cronet/android/java/src/org/chromium/net/AsyncUrlRequestFactory.java
@@ -0,0 +1,26 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.net;
+
+import java.net.URL;
+import java.util.concurrent.Executor;
+
+/**
+ * Created by mef on 8/29/14.
mmenke 2014/09/02 19:48:03 ?
mef 2014/09/03 20:58:58 Done. Autodoc. :)
+ */
+public class AsyncUrlRequestFactory {
+ /**
+ * Creates an AsyncUrlRequest object. All AsyncUrlRequest functions must
+ * be called on the executor’s thread, and all callbacks will be called
+ * on the executor’s thread as well.
mmenke 2014/09/02 19:48:03 nit: Executor (x3)
mef 2014/09/03 20:58:58 Done.
+ * createAsyncRequest itself may be called on any thread.
+ * @param url
+ * @param executor
+ * @return
+ */
+ public AsyncUrlRequest createAsyncRequest(URL url, Executor executor) {
mef 2014/09/03 20:58:58 I think it also needs to take listener.
+ return new ChromiumAsyncUrlRequest();
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698