Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Side by Side Diff: components/cronet/android/java/src/org/chromium/net/AsyncUrlRequestFactory.java

Issue 520093002: Initial declaration of Cronet Async API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 package org.chromium.net;
6
7 import java.net.URL;
8 import java.util.concurrent.Executor;
9
10 /**
11 * Created by mef on 8/29/14.
mmenke 2014/09/02 19:48:03 ?
mef 2014/09/03 20:58:58 Done. Autodoc. :)
12 */
13 public class AsyncUrlRequestFactory {
14 /**
15 * Creates an AsyncUrlRequest object. All AsyncUrlRequest functions must
16 * be called on the executor’s thread, and all callbacks will be called
17 * on the executor’s thread as well.
mmenke 2014/09/02 19:48:03 nit: Executor (x3)
mef 2014/09/03 20:58:58 Done.
18 * createAsyncRequest itself may be called on any thread.
19 * @param url
20 * @param executor
21 * @return
22 */
23 public AsyncUrlRequest createAsyncRequest(URL url, Executor executor) {
mef 2014/09/03 20:58:58 I think it also needs to take listener.
24 return new ChromiumAsyncUrlRequest();
25 }
26 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698