Issue 51993002: IDL compiler: Remove creationContext from v8SetReturnValue* in Python CG

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 51993002: IDL compiler: Remove creationContext from v8SetReturnValue* in Python CG (Closed)

Created:
7 years, 1 month ago by Nils Barth (inactive)

Modified:
7 years, 1 month ago

Reviewers:
haraken

CC:
blink-reviews, kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive, kouhei (in TOK)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

IDL compiler: Remove creationContext from v8SetReturnValue* in Python CG Python sync to r160892: We don't need to pass |creationContext| to v8SetReturnValue family https://codereview.chromium.org/50073004/ (Nice simplification -- thanks haraken!) BUG=239771 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160894

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -16 lines)			Patch
M	Source/bindings/scripts/unstable/v8_callback_interface.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/scripts/unstable/v8_methods.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/scripts/unstable/v8_types.py	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/bindings/templates/interface.h	View	4 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/51993002/1

7 years, 1 month ago (2013-10-30 03:24:06 UTC) #2

Nils Barth (inactive)

On 2013/10/30 03:20:49, haraken wrote: > LGTM. Thanks for the sync. n/p -- that's what ...

7 years, 1 month ago (2013-10-30 03:24:09 UTC) #3

Message was sent while issue was closed.

Change committed as 160894

Expand Messages | Collapse Messages