Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 51993002: IDL compiler: Remove creationContext from v8SetReturnValue* in Python CG (Closed)

Created:
7 years, 1 month ago by Nils Barth (inactive)
Modified:
7 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: Remove creationContext from v8SetReturnValue* in Python CG Python sync to r160892: We don't need to pass |creationContext| to v8SetReturnValue family https://codereview.chromium.org/50073004/ (Nice simplification -- thanks haraken!) BUG=239771 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160894

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M Source/bindings/scripts/unstable/v8_callback_interface.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/unstable/v8_methods.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/unstable/v8_types.py View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/templates/interface.h View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
haraken
LGTM. Thanks for the sync.
7 years, 1 month ago (2013-10-30 03:20:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/51993002/1
7 years, 1 month ago (2013-10-30 03:24:06 UTC) #2
Nils Barth (inactive)
On 2013/10/30 03:20:49, haraken wrote: > LGTM. Thanks for the sync. n/p -- that's what ...
7 years, 1 month ago (2013-10-30 03:24:09 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-30 03:24:20 UTC) #4
Message was sent while issue was closed.
Change committed as 160894

Powered by Google App Engine
This is Rietveld 408576698