Source/bindings/scripts/unstable/v8_methods.py - Issue 51993002: IDL compiler: Remove creationContext from v8SetReturnValue* in Python CG

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/unstable/v8_methods.py

Issue 51993002: IDL compiler: Remove creationContext from v8SetReturnValue* in Python CG (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/unstable/v8_methods.py

diff --git a/Source/bindings/scripts/unstable/v8_methods.py b/Source/bindings/scripts/unstable/v8_methods.py

index 48df4042d0069cbb42df746d3b4c86a866ec2cbb..cf8595858f2284c4b095c18f6893579f632d6d53 100644

--- a/Source/bindings/scripts/unstable/v8_methods.py

+++ b/Source/bindings/scripts/unstable/v8_methods.py

@@ -81,7 +81,7 @@ def cpp_method(method, number_of_arguments):

idl_type = method.idl_type

if idl_type == 'void':

return cpp_value

- return v8_types.v8_set_return_value(idl_type, cpp_value, callback_info='args', creation_context='args.Holder()', isolate='args.GetIsolate()')

+ return v8_types.v8_set_return_value(idl_type, cpp_value, callback_info='args', isolate='args.GetIsolate()')

def custom_signature(arguments):