Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 519693002: Properly handle forwarding factory constructors in type inference. (Closed)

Created:
6 years, 3 months ago by herhut
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Properly handle forwarding factory constructors in type inference. BUG= http://dartbug.com/18257 R=karlklose@google.com, johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=39695

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart View 2 chunks +11 lines, -0 lines 0 comments Download
A tests/language/forwarding_factory_constructor_default_values_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
herhut
Patchset #1 (id:1) has been deleted
6 years, 3 months ago (2014-08-29 11:00:08 UTC) #1
herhut
Patchset #1 (id:20001) has been deleted
6 years, 3 months ago (2014-08-29 11:01:12 UTC) #2
herhut
6 years, 3 months ago (2014-08-29 11:01:59 UTC) #3
karlklose
karlklose@google.com changed reviewers: + karlklose@google.com
6 years, 3 months ago (2014-08-29 11:13:32 UTC) #4
karlklose
LGTM.
6 years, 3 months ago (2014-08-29 11:13:32 UTC) #5
herhut
Committed patchset #1 (id:40001) manually as 39695 (presubmit successful).
6 years, 3 months ago (2014-08-29 11:19:38 UTC) #6
herhut
On 2014/08/29 11:13:32, karlklose wrote: > LGTM. Thanks!
6 years, 3 months ago (2014-08-29 11:19:51 UTC) #7
Johnni Winther
6 years, 3 months ago (2014-08-29 11:21:01 UTC) #8
Message was sent while issue was closed.
LGTM Thanks!

Powered by Google App Engine
This is Rietveld 408576698