Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 519663002: Use optional default value syntax in Selection.idl (Closed)

Created:
6 years, 3 months ago by Sunil Ratnu
Modified:
6 years, 3 months ago
CC:
blink-reviews, arv+blink, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use optional default value syntax in Selection.idl Since now the support for optional default value syntax is present, so using it now in Selection.idl. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181147

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Using default syntax in collapse() method as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M Source/core/editing/DOMSelection.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/editing/DOMSelection.cpp View 1 2 chunks +0 lines, -12 lines 0 comments Download
M Source/core/editing/Selection.idl View 1 2 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Sunil Ratnu
sunil.ratnu@samsung.com changed reviewers: + yoichio@chromium.org, yosin@chromium.org, yutak@chromium.org
6 years, 3 months ago (2014-08-29 10:30:37 UTC) #1
Sunil Ratnu
Please review this. Thanks!
6 years, 3 months ago (2014-08-29 10:30:37 UTC) #2
yosin_UTC9
LGTM Thanks!
6 years, 3 months ago (2014-09-01 01:00:34 UTC) #3
yoichio
lgtm
6 years, 3 months ago (2014-09-01 01:25:17 UTC) #4
Yuta Kitamura
lgtm
6 years, 3 months ago (2014-09-01 03:52:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/519663002/10004
6 years, 3 months ago (2014-09-01 04:32:45 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-01 05:13:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:10004) as 181147

Powered by Google App Engine
This is Rietveld 408576698