Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Unified Diff: Source/core/editing/Selection.idl

Issue 519663002: Use optional default value syntax in Selection.idl (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Using default syntax in collapse() method as well Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/DOMSelection.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/Selection.idl
diff --git a/Source/core/editing/Selection.idl b/Source/core/editing/Selection.idl
index dc27b0d9bfbe2d06112f4fcaed18e339ecad9d87..fc498024419559ba536e6f60291711a1ca350339 100644
--- a/Source/core/editing/Selection.idl
+++ b/Source/core/editing/Selection.idl
@@ -45,14 +45,13 @@
readonly attribute long focusOffset;
readonly attribute boolean isCollapsed;
- [RaisesException, TypeChecking=Interface] void collapse(Node node, optional long offset);
+ [RaisesException, TypeChecking=Interface] void collapse(Node node, optional long offset = 0);
[RaisesException] void collapseToStart();
[RaisesException] void collapseToEnd();
- // FIXME: should be: optional long offset = 0 http://crbug.com/258153
// We mark offset as optional, defaulting to 0; this differs from spec.
// http://crbug.com/384966
- [RaisesException, TypeChecking=Interface] void extend(Node node, optional long offset);
+ [RaisesException, TypeChecking=Interface] void extend(Node node, optional long offset = 0);
[RaisesException] void selectAllChildren([Default=Undefined] optional Node node);
[CustomElementCallbacks] void deleteFromDocument();
@@ -88,7 +87,7 @@
[Default=Undefined] optional Node extentNode,
[Default=Undefined] optional long extentOffset);
[ImplementedAs=collapse, MeasureAs=SelectionSetPosition, RaisesException, TypeChecking=Interface] void setPosition(Node node,
- optional long offset);
+ optional long offset = 0);
// IE extensions
// http://msdn.microsoft.com/en-us/library/ms535869(VS.85).aspx
« no previous file with comments | « Source/core/editing/DOMSelection.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698