Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: cc/layers/solid_color_layer_impl.cc

Issue 519583003: Use the solid color detection to create solid layers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Passed the right color to the quad Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/solid_color_layer_impl.cc
diff --git a/cc/layers/solid_color_layer_impl.cc b/cc/layers/solid_color_layer_impl.cc
index a88c53e8e58aa9279065fb5b22cc9c5f1494f31f..acc30db22e034e40a08b712d46005423660a2215 100644
--- a/cc/layers/solid_color_layer_impl.cc
+++ b/cc/layers/solid_color_layer_impl.cc
@@ -26,37 +26,8 @@ void SolidColorLayerImpl::AppendQuads(
RenderPass* render_pass,
const OcclusionTracker<LayerImpl>& occlusion_tracker,
AppendQuadsData* append_quads_data) {
- SharedQuadState* shared_quad_state =
- render_pass->CreateAndAppendSharedQuadState();
- PopulateSharedQuadState(shared_quad_state);
-
- AppendDebugBorderQuad(
- render_pass, content_bounds(), shared_quad_state, append_quads_data);
-
- // We create a series of smaller quads instead of just one large one so that
- // the culler can reduce the total pixels drawn.
- int width = content_bounds().width();
- int height = content_bounds().height();
- for (int x = 0; x < width; x += tile_size_) {
- for (int y = 0; y < height; y += tile_size_) {
- gfx::Rect quad_rect(x,
- y,
- std::min(width - x, tile_size_),
- std::min(height - y, tile_size_));
- gfx::Rect visible_quad_rect = occlusion_tracker.UnoccludedContentRect(
- quad_rect, draw_properties().target_space_transform);
- if (visible_quad_rect.IsEmpty())
- continue;
-
- SolidColorDrawQuad* quad =
- render_pass->CreateAndAppendDrawQuad<SolidColorDrawQuad>();
- quad->SetNew(shared_quad_state,
- quad_rect,
- visible_quad_rect,
- background_color(),
- false);
- }
- }
+ AppendSolidQuads(
+ render_pass, occlusion_tracker, append_quads_data, background_color());
}
const char* SolidColorLayerImpl::LayerTypeAsString() const {

Powered by Google App Engine
This is Rietveld 408576698