Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 51953003: remove contains(x,y) for rects and rrects ... not well defined, and unused (Closed)

Created:
7 years, 1 month ago by reed1
Modified:
6 years, 10 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

remove contains(x,y) for rects and rrects ... not well defined, and unused BUG= R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=12022

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -174 lines) Patch
M include/core/SkRRect.h View 1 chunk +0 lines, -24 lines 0 comments Download
M include/core/SkRect.h View 1 chunk +1 line, -28 lines 0 comments Download
M src/core/SkPath.cpp View 1 chunk +5 lines, -2 lines 2 comments Download
M src/core/SkRRect.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
M tests/RoundRectTest.cpp View 5 chunks +0 lines, -99 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
reed1
7 years, 1 month ago (2013-10-30 15:58:47 UTC) #1
robertphillips
lgtm + somewhat important question https://codereview.chromium.org/51953003/diff/1/src/core/SkPath.cpp File src/core/SkPath.cpp (right): https://codereview.chromium.org/51953003/diff/1/src/core/SkPath.cpp#newcode2964 src/core/SkPath.cpp:2964: static bool contains_inclusive(const SkRect& ...
7 years, 1 month ago (2013-10-30 17:18:48 UTC) #2
reed1
https://codereview.chromium.org/51953003/diff/1/src/core/SkPath.cpp File src/core/SkPath.cpp (right): https://codereview.chromium.org/51953003/diff/1/src/core/SkPath.cpp#newcode2964 src/core/SkPath.cpp:2964: static bool contains_inclusive(const SkRect& r, SkScalar x, SkScalar y) ...
7 years, 1 month ago (2013-10-30 17:38:53 UTC) #3
reed1
Committed patchset #1 manually as r12022 (presubmit successful).
7 years, 1 month ago (2013-10-30 17:39:49 UTC) #4
zac
6 years, 10 months ago (2014-02-06 23:06:29 UTC) #5
Message was sent while issue was closed.
On 2013/10/30 17:39:49, reed1 wrote:
> Committed patchset #1 manually as r12022 (presubmit successful).

We were. :-( update skia in our platform and it went missing. oh well. easy to
replace.

Powered by Google App Engine
This is Rietveld 408576698