Issue 519503002: Never clobber all of build in landmines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 519503002: Never clobber all of build in landmines (Closed)

Created:
6 years, 3 months ago by scottmg

Modified:
6 years, 3 months ago

Reviewers:
Ken Russell (switch to Gerrit), iannucci

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Never clobber all of build in landmines We don't support msvs any more anyway, and clobbering all of build/ is always a bad idea. (I'm not sure this'll fix anything, but maybe we'll get a better error.) R=kbr@chromium.org,iannucci@chromium.org BUG=408839 Committed: https://crrev.com/e72944be164918acb81933d0742e1369e51f2958 Cr-Commit-Position: refs/heads/master@{#292554}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	build/landmines.py	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 6 (0 generated)

Ken Russell (switch to Gerrit)

I think this should be fine and not impact any of the bots. If it ...

6 years, 3 months ago (2014-08-29 00:13:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/519503002/1

6 years, 3 months ago (2014-08-29 01:38:34 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as b2870d6b5f88723d4c719c501c4965a2ac33af7b

6 years, 3 months ago (2014-08-29 02:37:54 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:05:37 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e72944be164918acb81933d0742e1369e51f2958
Cr-Commit-Position: refs/heads/master@{#292554}