build/landmines.py - Issue 519503002: Never clobber all of build in landmines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/landmines.py

Issue 519503002: Never clobber all of build in landmines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/landmines.py

diff --git a/build/landmines.py b/build/landmines.py

index b62e75851cb4e74581440943a36dd9631fc772f1..f7dc07d1cb27d761a88c550f7c03ed922fbd1079 100755

--- a/build/landmines.py

+++ b/build/landmines.py

@@ -44,8 +44,6 @@ def get_build_dir(build_tool, is_iphone=False):

ret = os.path.join(SRC_DIR, 'xcodebuild')

elif build_tool in ['make', 'ninja', 'ninja-ios']: # TODO: Remove ninja-ios.

ret = os.path.join(SRC_DIR, os.environ.get('CHROMIUM_OUT_DIR', 'out'))

- elif build_tool in ['msvs', 'vs', 'ib']:

- ret = os.path.join(SRC_DIR, 'build')

else:

raise NotImplementedError('Unexpected GYP_GENERATORS (%s)' % build_tool)

return os.path.abspath(ret)

« no previous file with comments | « no previous file | no next file » | no next file with comments »