Source/platform/fonts/mac/FontMac.cpp - Issue 519373002: Return width from drawText to stop re-measure in Canvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/mac/FontMac.cpp

Issue 519373002: Return width from drawText to stop re-measure in Canvas (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updating Test Expectation file Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/fonts/mac/FontMac.cpp

diff --git a/Source/platform/fonts/mac/FontMac.cpp b/Source/platform/fonts/mac/FontMac.cpp

index c522c82266b9f654f1d2bb47c5613be2517e57b9..3668bb42d98acc3497ab79b6588057ef0fce932b 100644

--- a/Source/platform/fonts/mac/FontMac.cpp

+++ b/Source/platform/fonts/mac/FontMac.cpp

@@ -172,7 +172,7 @@ void Font::drawTextBlob(GraphicsContext*, const SkTextBlob*, const SkPoint&) con

// FIXME: Add text blob support to FontMac.

}

-PassTextBlobPtr Font::buildTextBlob(const GlyphBuffer& glyphBuffer, float initialAdvance, const FloatRect& bounds) const

+PassTextBlobPtr Font::buildTextBlob(const GlyphBuffer& glyphBuffer, float initialAdvance, const FloatRect& bounds, float& advance) const

{

// FIXME: Add text blob support to FontMac.

return nullptr;

« no previous file with comments | « Source/platform/fonts/mac/FontComplexTextMac.cpp ('k') | Source/platform/graphics/GraphicsContext.cpp » ('j') | no next file with comments »