Source/platform/fonts/mac/FontMac.cpp - Issue 519373002: Return width from drawText to stop re-measure in Canvas

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/platform/fonts/mac/FontMac.cpp

Issue 519373002: Return width from drawText to stop re-measure in Canvas (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updating Test Expectation file Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2011 Google Inc. All rights reserved.	2 * Copyright (c) 2011 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 154 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
165 }	165 }

166 if (font->platformData().orientation() == Vertical)	166 if (font->platformData().orientation() == Vertical)

167 gc->restore();	167 gc->restore();

168 }	168 }

169	169

170 void Font::drawTextBlob(GraphicsContext, const SkTextBlob, const SkPoint&) con st	170 void Font::drawTextBlob(GraphicsContext, const SkTextBlob, const SkPoint&) con st

171 {	171 {

172 // FIXME: Add text blob support to FontMac.	172 // FIXME: Add text blob support to FontMac.

173 }	173 }

174	174

175 PassTextBlobPtr Font::buildTextBlob(const GlyphBuffer& glyphBuffer, float initia lAdvance, const FloatRect& bounds) const	175 PassTextBlobPtr Font::buildTextBlob(const GlyphBuffer& glyphBuffer, float initia lAdvance, const FloatRect& bounds, float& advance) const

176 {	176 {

177 // FIXME: Add text blob support to FontMac.	177 // FIXME: Add text blob support to FontMac.

178 return nullptr;	178 return nullptr;

179 }	179 }

180	180

181 } // namespace blink	181 } // namespace blink

OLD	NEW

« no previous file with comments | « Source/platform/fonts/mac/FontComplexTextMac.cpp ('k') | Source/platform/graphics/GraphicsContext.cpp » ('j') | no next file with comments »