Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 51923002: Move password_form_fill_data_unittest.cc into components_unittests. (Closed)

Created:
7 years, 1 month ago by tfarina
Modified:
7 years, 1 month ago
Reviewers:
Lei Zhang, Jói
CC:
chromium-reviews
Visibility:
Public.

Description

Move password_form_fill_data_unittest.cc into components_unittests. BUG=140037 TEST=components_unittests R=joi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231853

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 2 comments Download
M components/components_tests.gyp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
Joi -> components Lei -> chrome https://codereview.chromium.org/51923002/diff/1/chrome/chrome_tests_unit.gypi File chrome/chrome_tests_unit.gypi (right): https://codereview.chromium.org/51923002/diff/1/chrome/chrome_tests_unit.gypi#newcode1963 chrome/chrome_tests_unit.gypi:1963: '../components/autofill/core/browser/webdata/autofill_entry_unittest.cc', I haven't ...
7 years, 1 month ago (2013-10-30 01:10:10 UTC) #1
Lei Zhang
lgtm
7 years, 1 month ago (2013-10-30 02:05:40 UTC) #2
Lei Zhang
Also, BUG=140037 https://codereview.chromium.org/51923002/diff/1/chrome/chrome_tests_unit.gypi File chrome/chrome_tests_unit.gypi (right): https://codereview.chromium.org/51923002/diff/1/chrome/chrome_tests_unit.gypi#newcode1963 chrome/chrome_tests_unit.gypi:1963: '../components/autofill/core/browser/webdata/autofill_entry_unittest.cc', On 2013/10/30 01:10:10, tfarina wrote: > ...
7 years, 1 month ago (2013-10-30 02:20:29 UTC) #3
tfarina
On 2013/10/30 02:20:29, Lei Zhang wrote: > Also, BUG=140037 > Done. > https://codereview.chromium.org/51923002/diff/1/chrome/chrome_tests_unit.gypi > File ...
7 years, 1 month ago (2013-10-30 02:22:20 UTC) #4
Jói
LGTM, thanks.
7 years, 1 month ago (2013-10-30 10:40:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/51923002/1
7 years, 1 month ago (2013-10-30 15:03:00 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-10-30 16:48:01 UTC) #7
Message was sent while issue was closed.
Change committed as 231853

Powered by Google App Engine
This is Rietveld 408576698