Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 50783008: Break WebDataServiceAutofillTest's chrome dependency. (Closed)

Created:
7 years, 1 month ago by Lei Zhang
Modified:
7 years, 1 month ago
Reviewers:
Jói
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, blundell, tfarina
Visibility:
Public.

Description

Break WebDataServiceAutofillTest's chrome dependency. BUG=140037 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232047

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -45 lines) Patch
M components/autofill/core/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/webdata/web_data_service_unittest.cc View 17 chunks +17 lines, -44 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
7 years, 1 month ago (2013-10-30 02:21:02 UTC) #1
Jói
LGTM
7 years, 1 month ago (2013-10-30 10:39:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/50783008/1
7 years, 1 month ago (2013-10-30 19:55:34 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=215976
7 years, 1 month ago (2013-10-30 22:10:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/50783008/1
7 years, 1 month ago (2013-10-30 23:21:44 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 08:06:38 UTC) #6
Message was sent while issue was closed.
Change committed as 232047

Powered by Google App Engine
This is Rietveld 408576698