Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Unified Diff: ui/events/event.cc

Issue 519113002: Do not mutate ui::Event properties during nested event processing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments changed Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/event.h ('k') | ui/events/event_processor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/event.cc
diff --git a/ui/events/event.cc b/ui/events/event.cc
index 27de2a96b6a150891a4632df87890562f06a4eb0..3b3c16145c28fe90c3eb176c63ae2d04edfe3754 100644
--- a/ui/events/event.cc
+++ b/ui/events/event.cc
@@ -111,6 +111,40 @@ namespace ui {
////////////////////////////////////////////////////////////////////////////////
// Event
+// static
+scoped_ptr<Event> Event::Clone(const Event& event) {
+ if (event.IsKeyEvent()) {
+ return scoped_ptr<Event>(new KeyEvent(static_cast<const KeyEvent&>(event)));
+ }
+
+ if (event.IsMouseEvent()) {
+ if (event.IsMouseWheelEvent()) {
+ return scoped_ptr<Event>(
+ new MouseWheelEvent(static_cast<const MouseWheelEvent&>(event)));
+ }
+
+ return scoped_ptr<Event>(
+ new MouseEvent(static_cast<const MouseEvent&>(event)));
+ }
+
+ if (event.IsTouchEvent()) {
+ return scoped_ptr<Event>(
+ new TouchEvent(static_cast<const TouchEvent&>(event)));
+ }
+
+ if (event.IsGestureEvent()) {
+ return scoped_ptr<Event>(
+ new GestureEvent(static_cast<const GestureEvent&>(event)));
+ }
+
+ if (event.IsScrollEvent()) {
+ return scoped_ptr<Event>(
+ new ScrollEvent(static_cast<const ScrollEvent&>(event)));
+ }
+
+ return scoped_ptr<Event>(new Event(event));
+}
+
Event::~Event() {
if (delete_native_event_)
ReleaseCopiedNativeEvent(native_event_);
« no previous file with comments | « ui/events/event.h ('k') | ui/events/event_processor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698