Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1528)

Unified Diff: ui/events/event_processor.cc

Issue 519113002: Do not mutate ui::Event properties during nested event processing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments changed Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/event.cc ('k') | ui/events/event_processor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/event_processor.cc
diff --git a/ui/events/event_processor.cc b/ui/events/event_processor.cc
index 3077cc85b168aea483a9e506021af80b5e64375e..e9f47c353f74442bc6d9e20154cd88b155cdded0 100644
--- a/ui/events/event_processor.cc
+++ b/ui/events/event_processor.cc
@@ -18,8 +18,25 @@ EventDispatchDetails EventProcessor::OnEventFromSource(Event* event) {
PrepareEventForDispatch(event);
EventTarget* target = targeter->FindTargetForEvent(root, event);
+ // If the event is in the process of being dispatched or has already been
+ // dispatched, then dispatch a copy of the event instead.
+ scoped_ptr<Event> event_copy;
+ if (event->phase() != EP_PREDISPATCH)
+ event_copy = Event::Clone(*event);
+
while (target) {
- EventDispatchDetails details = DispatchEvent(target, event);
+ EventDispatchDetails details;
+ if (event_copy) {
+ details = DispatchEvent(target, event_copy.get());
+
+ if (event_copy->stopped_propagation())
+ event->StopPropagation();
+ else if (event_copy->handled())
+ event->SetHandled();
+ } else {
+ details = DispatchEvent(target, event);
+ }
+
if (details.dispatcher_destroyed ||
details.target_destroyed ||
event->handled()) {
« no previous file with comments | « ui/events/event.cc ('k') | ui/events/event_processor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698