Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 519003003: Tell synthetic attribute nodes inside shadow DOM about move to new Document (Closed)

Created:
6 years, 3 months ago by Sami
Modified:
6 years, 3 months ago
Reviewers:
hayato, esprehn, kochi, eseidel
CC:
esprehn, aklein, blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, dominicc (has gone to gerrit), eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Tell synthetic attribute nodes inside shadow DOM about move to new Document Node::didMoveToNewDocument() is called to notify a Node that it has been moved under a new Document. This patch fixes a bug in TreeScopeAdopter where this notification was not done for synthetic attribute nodes inside a shadow DOM. The bug caused an issue where an event handler registered for an attribute node was not correctly unregistered when the parent element was moved to a new document. BUG=407477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181302

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -2 lines) Patch
A LayoutTests/fast/events/event-listener-on-attribute-inside-shadow-dom.html View 1 chunk +30 lines, -0 lines 0 comments Download
A + LayoutTests/fast/events/event-listener-on-attribute-inside-shadow-dom-expected.txt View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/core/dom/TreeScopeAdopter.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Sami
Hi Kent, are you a good person for reviewing this patch?
6 years, 3 months ago (2014-09-01 18:14:27 UTC) #2
tkent
+hayato, kochi
6 years, 3 months ago (2014-09-02 00:09:38 UTC) #4
hayato
Could someone add me to cc list of bug 407477? I couldn't see it.
6 years, 3 months ago (2014-09-02 02:06:57 UTC) #5
Sami
On 2014/09/02 02:06:57, hayato wrote: > Could someone add me to cc list of bug ...
6 years, 3 months ago (2014-09-02 09:23:44 UTC) #6
eseidel
6 years, 3 months ago (2014-09-02 16:25:28 UTC) #8
hayato
LGTM, assuming this is not a regression.
6 years, 3 months ago (2014-09-03 05:54:22 UTC) #9
esprehn
lgtm
6 years, 3 months ago (2014-09-03 06:20:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/519003003/1
6 years, 3 months ago (2014-09-03 09:43:08 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-03 09:47:50 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181302

Powered by Google App Engine
This is Rietveld 408576698