Issue 51883010: Simplify HTMLTrackElement::didCompleteLoad

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 51883010: Simplify HTMLTrackElement::didCompleteLoad (Closed)

Created:
7 years, 1 month ago by philipj_slow

Modified:
7 years, 1 month ago

Reviewers:
Nate Chapin

CC:
blink-reviews, dglazkov+blink, nessy, adamk+blink_chromium.org, philipj_slow, vcarbune.chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@refTextTrackLoaderClient

Visibility:
Public.

Simplify HTMLTrackElement::didCompleteLoad It doesn't need to be virtual and didn't use the first argument. BUG=313287 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160971

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	Source/core/html/HTMLTrackElement.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLTrackElement.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/track/LoadableTextTrack.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/51883010/1

7 years, 1 month ago (2013-10-30 20:37:29 UTC) #3

Message was sent while issue was closed.

Change committed as 160971