Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: Source/core/html/HTMLTrackElement.cpp

Issue 51883010: Simplify HTMLTrackElement::didCompleteLoad (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@refTextTrackLoaderClient
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLTrackElement.h ('k') | Source/core/html/track/LoadableTextTrack.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLTrackElement.cpp
diff --git a/Source/core/html/HTMLTrackElement.cpp b/Source/core/html/HTMLTrackElement.cpp
index 4214e36684047ac1fdfb4e4488c2fee037539ab9..00231371f29abbb390559068a79d40348fd88eac 100644
--- a/Source/core/html/HTMLTrackElement.cpp
+++ b/Source/core/html/HTMLTrackElement.cpp
@@ -218,7 +218,7 @@ void HTMLTrackElement::loadTimerFired(Timer<HTMLTrackElement>*)
// 8. If the track element's parent is a media element then let CORS mode be the state of the parent media
// element's crossorigin content attribute. Otherwise, let CORS mode be No CORS.
if (!canLoadUrl(url)) {
- didCompleteLoad(ensureTrack(), HTMLTrackElement::Failure);
+ didCompleteLoad(HTMLTrackElement::Failure);
return;
}
@@ -250,7 +250,7 @@ bool HTMLTrackElement::canLoadUrl(const KURL& url)
return dispatchBeforeLoadEvent(url.string());
}
-void HTMLTrackElement::didCompleteLoad(LoadableTextTrack*, LoadStatus status)
+void HTMLTrackElement::didCompleteLoad(LoadStatus status)
{
// 4.8.10.12.3 Sourcing out-of-band text tracks (continued)
« no previous file with comments | « Source/core/html/HTMLTrackElement.h ('k') | Source/core/html/track/LoadableTextTrack.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698