Media gallery fixups for scoped_refptr<T> operator T* removal.

Media gallery fixups for scoped_refptr<T> operator T* removal.

BUG=110610
Committed: https://crrev.com/a07edc75077f184ff901495ce7af5764de67e057
Cr-Commit-Position: refs/heads/master@{#292664}

[dcheng, 2014-08-29 09:39:08]

dcheng@chromium.org changed reviewers:
+ estade@chromium.org

[dcheng, 2014-08-29 09:41:42]

Manual fixups for cases the automated conversion tool opted to skip.

In this case, since there were multiple iterations of turning a scoped_refptr
into a T* and then back into a scoped_refptr, I opted to just pass it as a const
scoped_refptr<T>& argument instead. In some places, the make_scoped_refptr was
even a no-op (the call to delegate->ReadBytes(...) in
mtp_file_stream_reader.cc).

[Lei Zhang, 2014-08-29 15:25:56]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2014-08-29 15:25:56]

lgtm

https://codereview.chromium.org/518743002/diff/20001/chrome/utility/media_gal...
File chrome/utility/media_galleries/image_metadata_extractor.cc (right):

https://codereview.chromium.org/518743002/diff/20001/chrome/utility/media_gal...
chrome/utility/media_galleries/image_metadata_extractor.cc:34: const
base::Callback<void(const scoped_refptr<net::DrainableIOBuffer>&)>&
can you add a typedef for the callback?

[dcheng, 2014-08-29 16:32:02]

https://codereview.chromium.org/518743002/diff/20001/chrome/utility/media_gal...
File chrome/utility/media_galleries/image_metadata_extractor.cc (right):

https://codereview.chromium.org/518743002/diff/20001/chrome/utility/media_gal...
chrome/utility/media_galleries/image_metadata_extractor.cc:34: const
base::Callback<void(const scoped_refptr<net::DrainableIOBuffer>&)>&
On 2014/08/29 15:25:56, Lei Zhang wrote:
> can you add a typedef for the callback?

Done.

[dcheng, 2014-08-29 16:32:28]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-08-29 16:33:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dcheng@chromium.org/518743002/40001

[commit-bot: I haz the power, 2014-08-29 17:45:05]

Committed patchset #3 (id:40001) as afb9b839e36735db10c49c5a8e42c01a5d101cae

[commit-bot: I haz the power, 2014-09-10 03:09:52]

Patchset 3 (id:??) landed as
https://crrev.com/a07edc75077f184ff901495ce7af5764de67e057
Cr-Commit-Position: refs/heads/master@{#292664}