chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.h - Issue 518743002: Media gallery fixups for scoped_refptr<T> operator T* removal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.h

Issue 518743002: Media gallery fixups for scoped_refptr<T> operator T* removal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add callback typedef Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac.mm ('k') | chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.h

diff --git a/chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.h b/chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.h

index f4f53ff4513d6d72bc8d3ee0cac1bd8ca23c83dd..eaae1ebe5ec72a1c98ae026c855dbf9bfabab947 100644

--- a/chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.h

+++ b/chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.h

@@ -104,11 +104,12 @@ class MTPDeviceDelegateImplWin : public MTPDeviceAsyncDelegate {

const CreateSnapshotFileSuccessCallback& success_callback,

const ErrorCallback& error_callback) OVERRIDE;

virtual bool IsStreaming() OVERRIDE;

- virtual void ReadBytes(

- const base::FilePath& device_file_path,

- net::IOBuffer* buf, int64 offset, int buf_len,

- const ReadBytesSuccessCallback& success_callback,

- const ErrorCallback& error_callback) OVERRIDE;

+ virtual void ReadBytes(const base::FilePath& device_file_path,

+ const scoped_refptr<net::IOBuffer>& buf,

+ int64 offset,

+ int buf_len,

+ const ReadBytesSuccessCallback& success_callback,

+ const ErrorCallback& error_callback) OVERRIDE;

virtual void CancelPendingTasksAndDeleteDelegate() OVERRIDE;

// Ensures the device is initialized for communication by doing a