chrome/browser/extensions/api/developer_private/developer_private_api.cc - Issue 518653002: Add the "options_ui" extension manifest field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 518653002: Add the "options_ui" extension manifest field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address kalman's comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/autotest_private/autotest_private_api.cc ('k') | chrome/browser/extensions/api/management/management_api.cc » ('j') | extensions/common/manifest_handlers/options_page_info.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc

diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

index 37736c4fe49e7ccb9d1aa13a0eff6b82e33039b6..2df7cb2b49afb07ec3fbc162d51d3964b102030c 100644

--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc

+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

@@ -64,6 +64,7 @@

#include "extensions/common/manifest_handlers/icons_handler.h"

#include "extensions/common/manifest_handlers/incognito_info.h"

#include "extensions/common/manifest_handlers/offline_enabled_info.h"

+#include "extensions/common/manifest_handlers/options_page_info.h"

#include "extensions/common/permissions/permissions_data.h"

#include "extensions/common/switches.h"

#include "grit/theme_resources.h"

@@ -430,9 +431,9 @@ DeveloperPrivateGetItemsInfoFunction::CreateItemInfo(const Extension& item,

info->homepage_url.reset(new std::string(

ManifestURL::GetHomepageURL(&item).spec()));

- if (!ManifestURL::GetOptionsPage(&item).is_empty()) {

+ if (!OptionsPageInfo::GetOptionsPage(&item).is_empty()) {

info->options_url.reset(

- new std::string(ManifestURL::GetOptionsPage(&item).spec()));

+ new std::string(OptionsPageInfo::GetOptionsPage(&item).spec()));

}

if (!ManifestURL::GetUpdateURL(&item).is_empty()) {