chrome/browser/extensions/api/autotest_private/autotest_private_api.cc - Issue 518653002: Add the "options_ui" extension manifest field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/autotest_private/autotest_private_api.cc

Issue 518653002: Add the "options_ui" extension manifest field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address kalman's comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/background/background_mode_manager.cc ('k') | chrome/browser/extensions/api/developer_private/developer_private_api.cc » ('j') | extensions/common/manifest_handlers/options_page_info.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/autotest_private/autotest_private_api.cc

diff --git a/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc b/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc

index da360aa725cb2a8fb8e9ad4a7ed91b2415064d61..9d62488165e463898f2d3caa6a88cb94f3adfe10 100644

--- a/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc

+++ b/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc

@@ -12,11 +12,11 @@

#include "chrome/browser/lifetime/application_lifetime.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/common/extensions/api/autotest_private.h"

-#include "chrome/common/extensions/manifest_url_handler.h"

#include "extensions/browser/extension_function_registry.h"

#include "extensions/browser/extension_registry.h"

#include "extensions/browser/extension_system.h"

#include "extensions/common/manifest_handlers/background_info.h"

+#include "extensions/common/manifest_handlers/options_page_info.h"

#include "extensions/common/permissions/api_permission_set.h"

#include "extensions/common/permissions/permission_set.h"

#include "extensions/common/permissions/permissions_data.h"

@@ -174,8 +174,8 @@ bool AutotestPrivateGetExtensionsInfoFunction::RunSync() {

extension_value->SetString("description", extension->description());

extension_value->SetString(

"backgroundUrl", BackgroundInfo::GetBackgroundURL(extension).spec());

- extension_value->SetString("optionsUrl",

- ManifestURL::GetOptionsPage(extension).spec());

+ extension_value->SetString(

+ "optionsUrl", OptionsPageInfo::GetOptionsPage(extension).spec());

extension_value->Set("hostPermissions",

GetHostPermissions(extension, false));