Move StringComparator<string16>::operator() to header

Move StringComparator<string16>::operator() to header

Enabling /Zc:inline on static release build results in

FAILED: E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x64 True chrome.dll "E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /IMPLIB:chrome.dll.lib /DLL /OUT:chrome.dll @chrome.dll.rsp" 2 mt.exe rc.exe "obj\chrome\chrome_main_dll.chrome.dll.intermediate.manifest" obj\chrome\chrome_main_dll.chrome.dll.generated.manifest ..\..\chrome\app\chrome.dll.manifest
browser_2.lib(browser_2.character_encoding.obj) : error LNK2019: unresolved external symbol "public: bool __cdecl l10n_util::StringComparator<class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > >::operator()(class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > const &,class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > const &)" (??R?$StringComparator@V?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@@l10n_util@@QEAA_NAEBV?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@0@Z) referenced in function "void __cdecl std::_Adjust_heap<struct CharacterEncoding::EncodingInfo *,__int64,struct CharacterEncoding::EncodingInfo,class l10n_util::StringComparator<struct CharacterEncoding::EncodingInfo> >(struct CharacterEncoding::EncodingInfo *,__int64,__int64,struct CharacterEncoding::EncodingInfo &&,class l10n_util::StringComparator<struct CharacterEncoding::EncodingInfo>)" (??$_Adjust_heap@PEAUEncodingInfo@CharacterEncoding@@_JU12@V?$StringComparator@UEncodingInfo@CharacterEncoding@@@l10n_util@@@std@@YAXPEAUEncodingInfo@CharacterEncoding@@_J1$$QEAU12@V?$StringComparator@UEncodingInfo@CharacterEncoding@@@l10n_util@@@Z)

browser_1.lib(browser_1.background_application_list_model.obj) : error LNK2001: unresolved external symbol "public: bool __cdecl l10n_util::StringComparator<class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > >::operator()(class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > const &,class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > const &)" (??R?$StringComparator@V?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@@l10n_util@@QEAA_NAEBV?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@0@Z)

So, move StringComparator<base::string16>::operator() into header and
mark it inline, so that it's available in all translation units where it's
used. The previous code was correct, but this makes all compilers happy.

/Zc:inline ref: http://msdn.microsoft.com/en-us/library/dn642448.aspx

R=rnk@chromium.org
TBR=jshin@chromium.org
BUG=350018
Committed: https://crrev.com/51d4852246362fc385663b932c2b0f6f1b4a6092
Cr-Commit-Position: refs/heads/master@{#292559}

[scottmg, 2014-08-28 20:50:25]

Bequeathing to you Reid due to
https://www.mail-archive.com/cfe-commits@cs.uiuc.edu/msg100160.html .

And I'm hoping you can confirm the it doesn't need to say the word "inline" to
be considered inline.

And maybe you want to investigate whether clang could/should be more aggressive
in not accepting code like this, maybe only on Windows.

[scottmg, 2014-08-28 21:19:06]

Hmm, not sure. Maybe this is a cl/link bug then?

[Reid Kleckner, 2014-08-28 21:25:48]

Yeah, I think this is an MSVC bug. Clang seems to think the specialization of a
method of a class template produces a strong symbol. If you do move it in a
header, you do need to add the inline keyword.

[Reid Kleckner, 2014-08-28 21:40:24]

We think we understand the MSVC bug: they seem to think that full
specializations of class template methods are implicitly inline.

A simple test case is something like:

$ cat t.cpp
template <typename T> struct A {
  static void foo() { T::invalid(); }
};
template <> void A<int>::foo() { }
void baz() {
  A<int>::foo();
}

$ cl -nologo /Zc:inline -O2 -c t.cpp && dumpbin /symbols t.obj | grep foo
t.cpp

We don't get a foo symbol, which is wrong. We get it right:

$ clang-cl -nologo /Zc:inline -O2 -c t.cpp && dumpbin /symbols t.obj | grep foo
009 00000000 SECT1  notype ()    External     | ?foo@?$A@H@@SAXXZ (public:
static void __cdecl A<int>::foo(void))

So, probably the solution is just to add inline and throw it in the header. The
code as written was correct, but oh well.

[scottmg, 2014-08-28 21:52:37]

On 2014/08/28 21:40:24, Reid Kleckner wrote:
> We think we understand the MSVC bug: they seem to think that full
> specializations of class template methods are implicitly inline.
> 
> A simple test case is something like:
> 
> $ cat t.cpp
> template <typename T> struct A {
>   static void foo() { T::invalid(); }
> };
> template <> void A<int>::foo() { }
> void baz() {
>   A<int>::foo();
> }
> 
> $ cl -nologo /Zc:inline -O2 -c t.cpp && dumpbin /symbols t.obj | grep foo
> t.cpp
> 
> We don't get a foo symbol, which is wrong. We get it right:
> 
> $ clang-cl -nologo /Zc:inline -O2 -c t.cpp && dumpbin /symbols t.obj | grep
foo
> 009 00000000 SECT1  notype ()    External     | ?foo@?$A@H@@SAXXZ (public:
> static void __cdecl A<int>::foo(void))
> 
> So, probably the solution is just to add inline and throw it in the header.
The
> code as written was correct, but oh well.

Thanks. I spammed that at trybots but mac sez:

FAILED: /Volumes/data/b/build/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/ui/base/l10n/ui_base.l10n_util.o.d -DV8_DEPRECATION_WARNINGS
-D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD
-DCR_CLANG_REVISION=214024 -DCOMPONENT_BUILD -DUSE_LIBJPEG_TURBO=1
-DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1
-DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY
-DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1
-DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY
-DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DDCHECK_ALWAYS_ON=1
-DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1
-DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1
-DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1
-DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static
-DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1
-DENABLE_MANAGED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1
-DENABLE_WIFI_BOOTSTRAPPING=1 -DUI_BASE_IMPLEMENTATION -DSKIA_DLL
-DGR_GL_IGNORE_ES3_MSAA=0 -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1
'-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"'
-DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1
-DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_IGNORE_PROPER_FRACTIONAL_SCALING
-DSK_SUPPORT_LEGACY_PICTURE_CLONE -DSK_SUPPORT_LEGACY_GETDEVICE
-DSK_IGNORE_ETC1_SUPPORT -DSK_IGNORE_GPU_DITHER -DSK_USE_POSIX_THREADS
-DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DU_USING_ICU_NAMESPACE=0
-DU_ENABLE_DYLOAD=0 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
-DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -Igen -I../..
-I../../skia/config -I../../third_party/skia/src/core
-I../../third_party/skia/include/core -I../../third_party/skia/include/effects
-I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu
-I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops
-I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports
-I../../third_party/skia/include/utils -I../../skia/ext
-I../../third_party/skia/include/utils/mac -I../../third_party/icu/source/i18n
-I../../third_party/icu/source/common -Igen/ui/resources -Igen/ui/strings
-isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk
-O0 -fvisibility=hidden -Werror -Wnewline-eof -mmacosx-version-min=10.6 -arch
i386 -Wall -Wendif-labels -Wextra -Wno-unused-parameter
-Wno-missing-field-initializers -Wno-selector-type-mismatch -Wheader-hygiene
-Wno-char-subscripts -Wno-unneeded-internal-declaration
-Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
-Wno-deprecated-register -std=gnu++11 -fno-rtti -fno-exceptions
-fvisibility-inlines-hidden -fno-threadsafe-statics -fno-slp-vectorize -Xclang
-load -Xclang
/Volumes/data/b/build/slave/mac/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
-Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics
-fno-strict-aliasing -fstack-protector-all -Wno-undefined-bool-conversion
-Wno-tautological-undefined-compare  -c ../../ui/base/l10n/l10n_util.cc -o
obj/ui/base/l10n/ui_base.l10n_util.o
In file included from ../../ui/base/l10n/l10n_util.cc:30:
../../ui/base/l10n/l10n_util_collator.h:109:1: error: ignoring 'inline' keyword
on explicit template instantiation
[-Werror,-Wstatic-inline-explicit-instantiation]
inline template <> UI_BASE_EXPORT
^
1 error generated.
ninja: build stopped: subcommand failed.

#if defined(_MSC_VER) && !defined(__clang__)
inline
#endif

ftw! :(

[scottmg, 2014-08-28 21:53:24]

On 2014/08/28 21:52:37, scottmg wrote:
> On 2014/08/28 21:40:24, Reid Kleckner wrote:
> > We think we understand the MSVC bug: they seem to think that full
> > specializations of class template methods are implicitly inline.
> > 
> > A simple test case is something like:
> > 
> > $ cat t.cpp
> > template <typename T> struct A {
> >   static void foo() { T::invalid(); }
> > };
> > template <> void A<int>::foo() { }
> > void baz() {
> >   A<int>::foo();
> > }
> > 
> > $ cl -nologo /Zc:inline -O2 -c t.cpp && dumpbin /symbols t.obj | grep foo
> > t.cpp
> > 
> > We don't get a foo symbol, which is wrong. We get it right:
> > 
> > $ clang-cl -nologo /Zc:inline -O2 -c t.cpp && dumpbin /symbols t.obj | grep
> foo
> > 009 00000000 SECT1  notype ()    External     | ?foo@?$A@H@@SAXXZ (public:
> > static void __cdecl A<int>::foo(void))
> > 
> > So, probably the solution is just to add inline and throw it in the header.
> The
> > code as written was correct, but oh well.
> 
> Thanks. I spammed that at trybots but mac sez:
> 
> FAILED: /Volumes/data/b/build/goma/gomacc
> ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
> obj/ui/base/l10n/ui_base.l10n_util.o.d -DV8_DEPRECATION_WARNINGS
> -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD
> -DCR_CLANG_REVISION=214024 -DCOMPONENT_BUILD -DUSE_LIBJPEG_TURBO=1
> -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1
> -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY
> -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1
> -DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY
> -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DDCHECK_ALWAYS_ON=1
> -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1
> -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1
> -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1
> -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static
> -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1
> -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1
-DENABLE_SETTINGS_APP=1
> -DENABLE_MANAGED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1
> -DENABLE_WIFI_BOOTSTRAPPING=1 -DUI_BASE_IMPLEMENTATION -DSKIA_DLL
> -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1
> '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"'
> -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1
> -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_IGNORE_PROPER_FRACTIONAL_SCALING
> -DSK_SUPPORT_LEGACY_PICTURE_CLONE -DSK_SUPPORT_LEGACY_GETDEVICE
> -DSK_IGNORE_ETC1_SUPPORT -DSK_IGNORE_GPU_DITHER -DSK_USE_POSIX_THREADS
> -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DU_USING_ICU_NAMESPACE=0
> -DU_ENABLE_DYLOAD=0 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
> -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -Igen -I../..
> -I../../skia/config -I../../third_party/skia/src/core
> -I../../third_party/skia/include/core -I../../third_party/skia/include/effects
> -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu
> -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops
> -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports
> -I../../third_party/skia/include/utils -I../../skia/ext
> -I../../third_party/skia/include/utils/mac -I../../third_party/icu/source/i18n
> -I../../third_party/icu/source/common -Igen/ui/resources -Igen/ui/strings
> -isysroot
>
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk
> -O0 -fvisibility=hidden -Werror -Wnewline-eof -mmacosx-version-min=10.6 -arch
> i386 -Wall -Wendif-labels -Wextra -Wno-unused-parameter
> -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wheader-hygiene
> -Wno-char-subscripts -Wno-unneeded-internal-declaration
> -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
> -Wno-deprecated-register -std=gnu++11 -fno-rtti -fno-exceptions
> -fvisibility-inlines-hidden -fno-threadsafe-statics -fno-slp-vectorize -Xclang
> -load -Xclang
>
/Volumes/data/b/build/slave/mac/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
> -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics
> -fno-strict-aliasing -fstack-protector-all -Wno-undefined-bool-conversion
> -Wno-tautological-undefined-compare  -c ../../ui/base/l10n/l10n_util.cc -o
> obj/ui/base/l10n/ui_base.l10n_util.o
> In file included from ../../ui/base/l10n/l10n_util.cc:30:
> ../../ui/base/l10n/l10n_util_collator.h:109:1: error: ignoring 'inline'
keyword
> on explicit template instantiation
> [-Werror,-Wstatic-inline-explicit-instantiation]
> inline template <> UI_BASE_EXPORT
> ^
> 1 error generated.
> ninja: build stopped: subcommand failed.
> 
> #if defined(_MSC_VER) && !defined(__clang__)
> inline
> #endif
> 
> ftw! :(

Er, wait. I'm a putz, hold on a sec.

[scottmg, 2014-08-28 22:32:43]

On 2014/08/28 21:53:24, scottmg wrote:
> On 2014/08/28 21:52:37, scottmg wrote:
> > On 2014/08/28 21:40:24, Reid Kleckner wrote:
> > > We think we understand the MSVC bug: they seem to think that full
> > > specializations of class template methods are implicitly inline.
> > > 
> > > A simple test case is something like:
> > > 
> > > $ cat t.cpp
> > > template <typename T> struct A {
> > >   static void foo() { T::invalid(); }
> > > };
> > > template <> void A<int>::foo() { }
> > > void baz() {
> > >   A<int>::foo();
> > > }
> > > 
> > > $ cl -nologo /Zc:inline -O2 -c t.cpp && dumpbin /symbols t.obj | grep foo
> > > t.cpp
> > > 
> > > We don't get a foo symbol, which is wrong. We get it right:
> > > 
> > > $ clang-cl -nologo /Zc:inline -O2 -c t.cpp && dumpbin /symbols t.obj |
grep
> > foo
> > > 009 00000000 SECT1  notype ()    External     | ?foo@?$A@H@@SAXXZ (public:
> > > static void __cdecl A<int>::foo(void))
> > > 
> > > So, probably the solution is just to add inline and throw it in the
header.
> > The
> > > code as written was correct, but oh well.
> > 
> > Thanks. I spammed that at trybots but mac sez:
> > 
> > FAILED: /Volumes/data/b/build/goma/gomacc
> > ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
> > obj/ui/base/l10n/ui_base.l10n_util.o.d -DV8_DEPRECATION_WARNINGS
> > -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD
> > -DCR_CLANG_REVISION=214024 -DCOMPONENT_BUILD -DUSE_LIBJPEG_TURBO=1
> > -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1
> > -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY
> > -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1
> > -DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY
> > -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DDCHECK_ALWAYS_ON=1
> > -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1
> > -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1
> > -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1
> > -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static
> > -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1
> > -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1
> -DENABLE_SETTINGS_APP=1
> > -DENABLE_MANAGED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1
> > -DENABLE_WIFI_BOOTSTRAPPING=1 -DUI_BASE_IMPLEMENTATION -DSKIA_DLL
> > -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1
> > '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"'
> > -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1
> > -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_IGNORE_PROPER_FRACTIONAL_SCALING
> > -DSK_SUPPORT_LEGACY_PICTURE_CLONE -DSK_SUPPORT_LEGACY_GETDEVICE
> > -DSK_IGNORE_ETC1_SUPPORT -DSK_IGNORE_GPU_DITHER -DSK_USE_POSIX_THREADS
> > -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DU_USING_ICU_NAMESPACE=0
> > -DU_ENABLE_DYLOAD=0 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
> > -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -Igen
-I../..
> > -I../../skia/config -I../../third_party/skia/src/core
> > -I../../third_party/skia/include/core
-I../../third_party/skia/include/effects
> > -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu
> > -I../../third_party/skia/include/lazy
-I../../third_party/skia/include/pathops
> > -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports
> > -I../../third_party/skia/include/utils -I../../skia/ext
> > -I../../third_party/skia/include/utils/mac
-I../../third_party/icu/source/i18n
> > -I../../third_party/icu/source/common -Igen/ui/resources -Igen/ui/strings
> > -isysroot
> >
>
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk
> > -O0 -fvisibility=hidden -Werror -Wnewline-eof -mmacosx-version-min=10.6
-arch
> > i386 -Wall -Wendif-labels -Wextra -Wno-unused-parameter
> > -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wheader-hygiene
> > -Wno-char-subscripts -Wno-unneeded-internal-declaration
> > -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
> > -Wno-deprecated-register -std=gnu++11 -fno-rtti -fno-exceptions
> > -fvisibility-inlines-hidden -fno-threadsafe-statics -fno-slp-vectorize
-Xclang
> > -load -Xclang
> >
>
/Volumes/data/b/build/slave/mac/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
> > -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics
> > -fno-strict-aliasing -fstack-protector-all -Wno-undefined-bool-conversion
> > -Wno-tautological-undefined-compare  -c ../../ui/base/l10n/l10n_util.cc -o
> > obj/ui/base/l10n/ui_base.l10n_util.o
> > In file included from ../../ui/base/l10n/l10n_util.cc:30:
> > ../../ui/base/l10n/l10n_util_collator.h:109:1: error: ignoring 'inline'
> keyword
> > on explicit template instantiation
> > [-Werror,-Wstatic-inline-explicit-instantiation]
> > inline template <> UI_BASE_EXPORT
> > ^
> > 1 error generated.
> > ninja: build stopped: subcommand failed.
> > 
> > #if defined(_MSC_VER) && !defined(__clang__)
> > inline
> > #endif
> > 
> > ftw! :(
> 
> Er, wait. I'm a putz, hold on a sec.

Putting the inline in the correct location seems to placate everyone.

[Reid Kleckner, 2014-08-28 22:37:07]

lgtm

Hooray, C++!

[scottmg, 2014-08-28 22:37:50]

scottmg@chromium.org changed reviewers:
+ jshin@chromium.org

[scottmg, 2014-08-28 22:38:04]

+jshin for OWNERS

[scottmg, 2014-08-28 22:38:29]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-08-28 22:39:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scottmg@chromium.org/518533002/40001

[commit-bot: I haz the power, 2014-08-28 23:47:17]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-29 01:28:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-29 01:28:28]

Try jobs failed on following builders:
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[scottmg, 2014-08-29 01:37:49]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-08-29 01:38:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scottmg@chromium.org/518533002/40001

[commit-bot: I haz the power, 2014-08-29 02:49:02]

Committed patchset #3 (id:40001) as 5d92161af8c783f87d9e67afea32230137c2a9ba

[commit-bot: I haz the power, 2014-09-10 03:05:47]

Patchset 3 (id:??) landed as
https://crrev.com/51d4852246362fc385663b932c2b0f6f1b4a6092
Cr-Commit-Position: refs/heads/master@{#292559}