Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Side by Side Diff: ui/base/l10n/l10n_util_collator.h

Issue 518533002: Move StringComparator<string16>::operator() to header (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/base/l10n/l10n_util.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_BASE_L10N_L10N_UTIL_COLLATOR_H_ 5 #ifndef UI_BASE_L10N_L10N_UTIL_COLLATOR_H_
6 #define UI_BASE_L10N_L10N_UTIL_COLLATOR_H_ 6 #define UI_BASE_L10N_L10N_UTIL_COLLATOR_H_
7 7
8 #include <algorithm> 8 #include <algorithm>
9 #include <functional> 9 #include <functional>
10 #include <string> 10 #include <string>
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 99
100 return StringComparator<base::string16>(collator_)(lhs_string_key, 100 return StringComparator<base::string16>(collator_)(lhs_string_key,
101 rhs_string_key); 101 rhs_string_key);
102 } 102 }
103 103
104 private: 104 private:
105 icu::Collator* collator_; 105 icu::Collator* collator_;
106 }; 106 };
107 107
108 // Specialization of operator() method for base::string16 version. 108 // Specialization of operator() method for base::string16 version.
109 template <> UI_BASE_EXPORT 109 template <>
110 bool StringComparator<base::string16>::operator()(const base::string16& lhs, 110 UI_BASE_EXPORT inline bool StringComparator<base::string16>::operator()(
111 const base::string16& rhs); 111 const base::string16& lhs,
112 const base::string16& rhs) {
113 // If we can not get collator instance for specified locale, just do simple
114 // string compare.
115 if (!collator_)
116 return lhs < rhs;
117 return base::i18n::CompareString16WithCollator(collator_, lhs, rhs) ==
118 UCOL_LESS;
119 }
112 120
113 // In place sorting of |elements| of a vector according to the string key of 121 // In place sorting of |elements| of a vector according to the string key of
114 // each element in the vector by using collation rules for |locale|. 122 // each element in the vector by using collation rules for |locale|.
115 // |begin_index| points to the start position of elements in the vector which 123 // |begin_index| points to the start position of elements in the vector which
116 // want to be sorted. |end_index| points to the end position of elements in the 124 // want to be sorted. |end_index| points to the end position of elements in the
117 // vector which want to be sorted 125 // vector which want to be sorted
118 template <class Element> 126 template <class Element>
119 void SortVectorWithStringKey(const std::string& locale, 127 void SortVectorWithStringKey(const std::string& locale,
120 std::vector<Element>* elements, 128 std::vector<Element>* elements,
121 unsigned int begin_index, 129 unsigned int begin_index,
(...skipping 20 matching lines...) Expand all
142 void SortVectorWithStringKey(const std::string& locale, 150 void SortVectorWithStringKey(const std::string& locale,
143 std::vector<Element>* elements, 151 std::vector<Element>* elements,
144 bool needs_stable_sort) { 152 bool needs_stable_sort) {
145 SortVectorWithStringKey<Element>(locale, elements, 0, elements->size(), 153 SortVectorWithStringKey<Element>(locale, elements, 0, elements->size(),
146 needs_stable_sort); 154 needs_stable_sort);
147 } 155 }
148 156
149 } // namespace l10n_util 157 } // namespace l10n_util
150 158
151 #endif // UI_BASE_L10N_L10N_UTIL_COLLATOR_H_ 159 #endif // UI_BASE_L10N_L10N_UTIL_COLLATOR_H_
OLDNEW
« no previous file with comments | « ui/base/l10n/l10n_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698