Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 518363002: Add a test to verify that the breakpad symbol-generating script actually exists. (Closed)

Created:
6 years, 3 months ago by Dirk Pranke
Modified:
6 years, 3 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Add a test to verify that the breakpad symbol-generating script actually exists. We moved the file as part of the work to rename //components/breakpad to //components/crash, but failed to update the path in webkitpy. It seems like a generally good idea to verify that the script does exist, as we clearly didn't have other test coverage for this and were just getting strange failures in run-webkit-tests. R=rsesek@chromium.org BUG=406410, 408644 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181128

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart_unittest.py View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dirk Pranke
6 years, 3 months ago (2014-08-29 23:55:42 UTC) #2
Robert Sesek
lgtm
6 years, 3 months ago (2014-08-30 01:06:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/518363002/1
6 years, 3 months ago (2014-08-30 01:15:31 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 3 months ago (2014-08-30 02:21:57 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-08-30 03:26:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181128

Powered by Google App Engine
This is Rietveld 408576698