Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart_unittest.py

Issue 518363002: Add a test to verify that the breakpad symbol-generating script actually exists. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2013 Google Inc. All rights reserved. 1 # Copyright (C) 2013 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 12 matching lines...) Expand all
23 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 23 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
24 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 24 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
25 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 25 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28 28
29 import unittest 29 import unittest
30 30
31 import cgi 31 import cgi
32 32
33 from webkitpy.common.host import Host
33 from webkitpy.common.host_mock import MockHost 34 from webkitpy.common.host_mock import MockHost
34 from webkitpy.common.system.executive_mock import MockExecutive 35 from webkitpy.common.system.executive_mock import MockExecutive
35 from webkitpy.layout_tests.breakpad.dump_reader_multipart import DumpReaderMulti part 36 from webkitpy.layout_tests.breakpad.dump_reader_multipart import DumpReaderMulti part
36 37
37 38
38 class TestDumpReaderMultipart(unittest.TestCase): 39 class TestDumpReaderMultipart(unittest.TestCase):
39 _MULTIPART_DUMP = [ 40 _MULTIPART_DUMP = [
40 '--boundary', 41 '--boundary',
41 'Content-Disposition: form-data; name="prod"', 42 'Content-Disposition: form-data; name="prod"',
42 '', 43 '',
43 'content_shell', 44 'content_shell',
44 '--boundary', 45 '--boundary',
45 'Content-Disposition: form-data; name="pid"', 46 'Content-Disposition: form-data; name="pid"',
46 '', 47 '',
47 '4711', 48 '4711',
48 '--boundary', 49 '--boundary',
49 'Content-Disposition: form-data; name="upload_file_minidump"; filename=" dump"', 50 'Content-Disposition: form-data; name="upload_file_minidump"; filename=" dump"',
50 'Content-Type: application/octet-stream', 51 'Content-Type: application/octet-stream',
51 '', 52 '',
52 'MDMP', 53 'MDMP',
53 '--boundary--', 54 '--boundary--',
54 ] 55 ]
55 56
57 def test_check_generate_breakpad_symbols_actually_exists(self):
58 host = Host()
59 dump_reader = DumpReaderMultipart(host, build_dir=None)
60 self.assertTrue(host.filesystem.exists(dump_reader._path_to_generate_bre akpad_symbols()))
61
56 def test_check_is_functional_breakpad_tools_not_found(self): 62 def test_check_is_functional_breakpad_tools_not_found(self):
57 host = MockHost() 63 host = MockHost()
58 64
59 build_dir = "/mock-checkout/out/Debug" 65 build_dir = "/mock-checkout/out/Debug"
60 host.filesystem.maybe_make_directory(build_dir) 66 host.filesystem.maybe_make_directory(build_dir)
61 dump_reader = DumpReaderMultipart(host, build_dir) 67 dump_reader = DumpReaderMultipart(host, build_dir)
62 dump_reader._file_extension = lambda: 'dmp' 68 dump_reader._file_extension = lambda: 'dmp'
63 dump_reader._binaries_to_symbolize = lambda: ['content_shell'] 69 dump_reader._binaries_to_symbolize = lambda: ['content_shell']
64 70
65 self.assertFalse(dump_reader.check_is_functional()) 71 self.assertFalse(dump_reader.check_is_functional())
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 dump_reader._file_extension = lambda: 'dmp' 106 dump_reader._file_extension = lambda: 'dmp'
101 dump_reader._binaries_to_symbolize = lambda: ['content_shell'] 107 dump_reader._binaries_to_symbolize = lambda: ['content_shell']
102 108
103 self.assertTrue(dump_reader.check_is_functional()) 109 self.assertTrue(dump_reader.check_is_functional())
104 self.assertEqual("MOCK output of child process", dump_reader._get_stack_ from_dump(dump_file)) 110 self.assertEqual("MOCK output of child process", dump_reader._get_stack_ from_dump(dump_file))
105 self.assertEqual(2, len(host.executive.calls)) 111 self.assertEqual(2, len(host.executive.calls))
106 cmd_line = " ".join(host.executive.calls[0]) 112 cmd_line = " ".join(host.executive.calls[0])
107 self.assertIn('generate_breakpad_symbols.py', cmd_line) 113 self.assertIn('generate_breakpad_symbols.py', cmd_line)
108 cmd_line = " ".join(host.executive.calls[1]) 114 cmd_line = " ".join(host.executive.calls[1])
109 self.assertIn('minidump_stackwalk', cmd_line) 115 self.assertIn('minidump_stackwalk', cmd_line)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698