Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2479)

Unified Diff: content/renderer/render_widget.cc

Issue 518123002: Always guard against IME events for all KeyPress. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove extra braces Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 3d693b95f9230d20494738dc0faa56e4d1d3af9e..eff4a70f26f90f329e738289e675acf9413066f5 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -941,14 +941,8 @@ void RenderWidget::OnHandleInputEvent(const blink::WebInputEvent* input_event,
// IME event guard here to make sure it does not interfere with other IME
// events.
scoped_ptr<ImeEventGuard> ime_event_guard_maybe;
- if (WebInputEvent::isKeyboardEventType(input_event->type)) {
- const WebKeyboardEvent& key_event =
- *static_cast<const WebKeyboardEvent*>(input_event);
- if (key_event.nativeKeyCode == AKEYCODE_FORWARD_DEL ||
- key_event.nativeKeyCode == AKEYCODE_DEL) {
- ime_event_guard_maybe.reset(new ImeEventGuard(this));
- }
- }
+ if (WebInputEvent::isKeyboardEventType(input_event->type))
+ ime_event_guard_maybe.reset(new ImeEventGuard(this));
#endif
base::AutoReset<const ui::LatencyInfo*> resetter(&current_event_latency_info_,
« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698