Always guard against IME events for all KeyPress.

content/renderer/render_widget.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_widget.h"
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
@@ skipping 916 matching lines @@
 void RenderWidget::OnHandleInputEvent(const blink::WebInputEvent* input_event,
                                       const ui::LatencyInfo& latency_info,
                                       bool is_keyboard_shortcut) {
   base::AutoReset<bool> handling_input_event_resetter(
       &handling_input_event_, true);
   if (!input_event)
     return;
   base::AutoReset<WebInputEvent::Type> handling_event_type_resetter(
       &handling_event_type_, input_event->type);
 #if defined(OS_ANDROID)
   // On Android, when the delete key or forward delete key is pressed using IME,

[aurimas (slooooooooow), 2014/08/29 18:27:21]

Please update the comment.

[bcwhite, 2014/08/29 18:47:12]

Done.

   // |AdapterInputConnection| generates input key events to make sure all JS
   // listeners that monitor KeyUp and KeyDown events receive the proper key
   // code. Since this input key event comes from IME, we need to set the
   // IME event guard here to make sure it does not interfere with other IME
   // events.
   scoped_ptr<ImeEventGuard> ime_event_guard_maybe;
-  if (WebInputEvent::isKeyboardEventType(input_event->type)) {
-    const WebKeyboardEvent& key_event =
-        *static_cast<const WebKeyboardEvent*>(input_event);
-    if (key_event.nativeKeyCode == AKEYCODE_FORWARD_DEL ||
-        key_event.nativeKeyCode == AKEYCODE_DEL) {
-      ime_event_guard_maybe.reset(new ImeEventGuard(this));
-    }
-  }
+  if (WebInputEvent::isKeyboardEventType(input_event->type))
+    ime_event_guard_maybe.reset(new ImeEventGuard(this));
 #endif
 
   base::AutoReset<const ui::LatencyInfo*> resetter(&current_event_latency_info_,
                                                    &latency_info);
 
   base::TimeTicks start_time;
   if (base::TimeTicks::IsHighResNowFastAndReliable())
     start_time = base::TimeTicks::HighResNow();
 
   const char* const event_name =
@@ skipping 1216 matching lines @@
 void RenderWidget::RegisterVideoHoleFrame(RenderFrameImpl* frame) {
   video_hole_frames_.AddObserver(frame);
 }
 
 void RenderWidget::UnregisterVideoHoleFrame(RenderFrameImpl* frame) {
   video_hole_frames_.RemoveObserver(frame);
 }
 #endif  // defined(VIDEO_HOLE)
 
 }  // namespace content