Always guard against IME events for all KeyPress.

Always guard against IME events for all KeyPress.

Previously, only BS/DEL set this guard but there are cases with keyboards
that send single characters immediately followed by a composition (e.g.
swiping words on stock Google keyboard) and we want to make sure that
there is no race condition where the actions taken in response to the
KeyPress don't cancel the following composition.

BUG=408678
Committed: https://crrev.com/d21e6ffc621be0848d0a7aae34bddf31487b7ab2
Cr-Commit-Position: refs/heads/master@{#293562}

[bcwhite, 2014-08-29 18:08:26]

bcwhite@chromium.org changed reviewers:
+ aurimas@chromium.org, guohui@chromium.org

[guohui, 2014-08-29 18:12:57]

lgtm

https://codereview.chromium.org/518123002/diff/1/content/renderer/render_widg...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/518123002/diff/1/content/renderer/render_widg...
content/renderer/render_widget.cc:946: }
nits: removes extra {}

[aurimas (slooooooooow), 2014-08-29 18:27:22]

https://codereview.chromium.org/518123002/diff/20001/content/renderer/render_...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/518123002/diff/20001/content/renderer/render_...
content/renderer/render_widget.cc:937: // On Android, when the delete key or
forward delete key is pressed using IME,
Please update the comment.

[bcwhite, 2014-08-29 18:47:12]

https://codereview.chromium.org/518123002/diff/20001/content/renderer/render_...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/518123002/diff/20001/content/renderer/render_...
content/renderer/render_widget.cc:937: // On Android, when the delete key or
forward delete key is pressed using IME,
On 2014/08/29 18:27:21, aurimas wrote:
> Please update the comment.

Done.

[bcwhite, 2014-08-29 18:52:06]

bcwhite@chromium.org changed reviewers:
+ jamesr@chromium.org, jdduke@chromium.org

[bcwhite, 2014-08-29 18:52:07]

jdduke@chromium.org: Please review changes in 
javatests

jamesr@chromium.org: Please review changes in 
content/renderer

[jdduke (slow), 2014-08-29 19:03:45]

On 2014/08/29 18:52:07, bcwhite wrote:
> mailto:jdduke@chromium.org: Please review changes in 
> javatests

aurimas@ will shortly be an OWNER here
(https://codereview.chromium.org/518133002/), so I'll defer to him.

https://codereview.chromium.org/518123002/diff/40001/content/public/android/j...
File
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
(right):

https://codereview.chromium.org/518123002/diff/40001/content/public/android/j...
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:476:
// three
Super nit: I'd put these comments in quotes to prevent any confusion "three",
"word", "test".

[bcwhite, 2014-08-29 19:05:55]

https://codereview.chromium.org/518123002/diff/40001/content/public/android/j...
File
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
(right):

https://codereview.chromium.org/518123002/diff/40001/content/public/android/j...
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:476:
// three
On 2014/08/29 19:03:45, jdduke wrote:
> Super nit: I'd put these comments in quotes to prevent any confusion "three",
> "word", "test".

:-)  Done

[bcwhite, 2014-09-02 22:02:08]

On 2014/08/29 19:05:55, bcwhite wrote:
>
https://codereview.chromium.org/518123002/diff/40001/content/public/android/j...
> File
>
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
> (right):
> 
>
https://codereview.chromium.org/518123002/diff/40001/content/public/android/j...
>
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:476:
> // three
> On 2014/08/29 19:03:45, jdduke wrote:
> > Super nit: I'd put these comments in quotes to prevent any confusion
"three",
> > "word", "test".
> 
> :-)  Done

This is blocking Beta.  Can we *not* delay it waiting for Aurimas to be an
official OWNER?

[aurimas (slooooooooow), 2014-09-02 22:08:06]

LGTM. Sorry it slipped through. Feel free to ping me over IM next time

[bcwhite, 2014-09-03 12:41:16]

On 2014/09/02 22:08:06, aurimas wrote:
> LGTM. Sorry it slipped through. Feel free to ping me over IM next time

jdduke, approval?

[jdduke (slow), 2014-09-03 13:04:25]

On 2014/09/03 12:41:16, bcwhite wrote:
> On 2014/09/02 22:08:06, aurimas wrote:
> > LGTM. Sorry it slipped through. Feel free to ping me over IM next time
> 
> jdduke, approval?

Sorry,thought aurimas@ was owner by now (patch to do so was in CQ). Rubberstamp
lgtm.

[bcwhite, 2014-09-03 14:20:22]

jamesr, ping?

[jamesr, 2014-09-03 17:30:25]

lgtm

[bcwhite, 2014-09-03 20:53:39]

The CQ bit was checked by bcwhite@chromium.org

[commit-bot: I haz the power, 2014-09-03 20:55:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bcwhite@chromium.org/518123002/60001

[commit-bot: I haz the power, 2014-09-04 02:51:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-04 02:51:41]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[bcwhite, 2014-09-04 17:38:31]

The CQ bit was checked by bcwhite@chromium.org

[commit-bot: I haz the power, 2014-09-04 17:49:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bcwhite@chromium.org/518123002/60001

[commit-bot: I haz the power, 2014-09-04 20:01:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-04 20:01:47]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[bcwhite, 2014-09-05 04:03:05]

The CQ bit was checked by bcwhite@chromium.org

[commit-bot: I haz the power, 2014-09-05 04:05:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bcwhite@chromium.org/518123002/60001

[commit-bot: I haz the power, 2014-09-05 06:03:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-05 06:03:07]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[bcwhite, 2014-09-05 12:32:58]

The CQ bit was checked by bcwhite@chromium.org

[commit-bot: I haz the power, 2014-09-05 12:34:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bcwhite@chromium.org/518123002/60001

[commit-bot: I haz the power, 2014-09-05 15:18:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-05 15:18:27]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[bcwhite, 2014-09-05 16:57:10]

The CQ bit was checked by bcwhite@chromium.org

[commit-bot: I haz the power, 2014-09-05 16:58:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bcwhite@chromium.org/518123002/100001

[commit-bot: I haz the power, 2014-09-05 17:15:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-05 17:15:29]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bcwhite, 2014-09-05 17:16:34]

The CQ bit was checked by bcwhite@chromium.org

[commit-bot: I haz the power, 2014-09-05 17:18:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bcwhite@chromium.org/518123002/100001

[commit-bot: I haz the power, 2014-09-05 18:49:59]

Committed patchset #6 (id:100001) as 88f55c7365673c38c414d79337bd7c1954fec012

[commit-bot: I haz the power, 2014-09-10 03:41:00]

Patchset 6 (id:??) landed as
https://crrev.com/d21e6ffc621be0848d0a7aae34bddf31487b7ab2
Cr-Commit-Position: refs/heads/master@{#293562}