Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: PRESUBMIT.py

Issue 518063002: Settings to control Add Person and Browse as Guest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app/generated_resources.grd » ('j') | chrome/browser/resources/options/browser_options.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index a3b4ec75c26a90f4d39c6faba9a438498d45683e..fac489a19ffd32650f8ba929b94ed8d2b166996a 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -1109,7 +1109,6 @@ def _GetIDLParseError(input_api, filename):
except ValueError as e:
return e
-
def _CheckParseErrors(input_api, output_api):
"""Check that IDL and JSON files do not contain syntax errors."""
actions = {
@@ -1119,7 +1118,7 @@ def _CheckParseErrors(input_api, output_api):
# These paths contain test data and other known invalid JSON files.
excluded_patterns = [
'test/data/',
- '^components/policy/resources/policy_templates.json$',
+ '^components[\\\/]policy[\\\/]resources[\\\/]policy_templates.json$',
Joao da Silva 2014/09/01 08:56:18 This has been fixed in https://codereview.chromium
Mike Lerman 2014/09/02 16:58:29 Perfect, just rebased. Thanks.
]
# Most JSON files are preprocessed and support comments, but these do not.
json_no_comments_patterns = [
« no previous file with comments | « no previous file | chrome/app/generated_resources.grd » ('j') | chrome/browser/resources/options/browser_options.css » ('J')

Powered by Google App Engine
This is Rietveld 408576698