Issue 518863002: Support both \ and / as path separators in regexes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 518863002: Support both \ and / as path separators in regexes. (Closed)

Created:
6 years, 3 months ago by Joao da Silva

Modified:
6 years, 3 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Support both \ and / as path separators in regexes. Also cleanup src/PRESUBMIT.py to use a common pattern for this. BUG=409029 Committed: https://crrev.com/718f8767f9e752ec1a14690617e589ba26c34c1d Cr-Commit-Position: refs/heads/master@{#292784}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -17 lines)			Patch
	M	PRESUBMIT.py	View		6 chunks	+17 lines, -17 lines	0 comments	Download

Total messages: 7 (1 generated)

Joao da Silva

joaodasilva@chromium.org changed reviewers: + maruel@chromium.org

6 years, 3 months ago (2014-08-29 15:49:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/518863002/1

6 years, 3 months ago (2014-08-30 09:03:36 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as c064f1aa6d997ad228ef31143e099ee5db5e1542

6 years, 3 months ago (2014-08-30 09:26:39 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:14:06 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/718f8767f9e752ec1a14690617e589ba26c34c1d
Cr-Commit-Position: refs/heads/master@{#292784}