Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 517803002: SkImageInfo will soon have a constructor, so can't init it with {} anymore (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

SkImageInfo will soon have a constructor, so can't init it with {} anymore needed for this CL https://codereview.chromium.org/517123002/ TBR= Committed: https://crrev.com/cd6c5704acdaa0f1779fe8c9e9dbeac0f33623ba Cr-Commit-Position: refs/heads/master@{#292556}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/browser/android/thumbnail/thumbnail_store.cc View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
reed1
reed@google.com changed reviewers: + miguelg@chromium.org, yfriedman@chromium.org
6 years, 3 months ago (2014-08-28 21:57:17 UTC) #1
reed1
need owner review for content/browser/android
6 years, 3 months ago (2014-08-28 21:57:17 UTC) #2
f(malita)
fmalita@chromium.org changed reviewers: + fmalita@chromium.org
6 years, 3 months ago (2014-08-28 22:15:32 UTC) #3
f(malita)
non-owner lgtm
6 years, 3 months ago (2014-08-28 22:15:32 UTC) #4
reed2
The CQ bit was checked by reed@chromium.org
6 years, 3 months ago (2014-08-29 01:47:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/517803002/1
6 years, 3 months ago (2014-08-29 01:48:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 77aaee19a86bec1f84054c0ffe18f944fc3ceb4c
6 years, 3 months ago (2014-08-29 02:42:02 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:05:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd6c5704acdaa0f1779fe8c9e9dbeac0f33623ba
Cr-Commit-Position: refs/heads/master@{#292556}

Powered by Google App Engine
This is Rietveld 408576698