Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 517793003: Reorder AudioMessageFilter shutdown. Remove spammy DCHECK. (Closed)

Created:
6 years, 3 months ago by DaleCurtis
Modified:
6 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reorder AudioMessageFilter shutdown. Remove spammy DCHECK. Fixes NULL pointer dereference when the RenderThreadImpl is destructed but outstanding HTMLMediaElement objects have not yet been garbage collected. Reordering will keep audio streams alive slightly longer, but that should be of no consequence since they would still respond to graceful shutdown attempts by any living AudioRendererImpls. BUG=408345 TEST=none Committed: https://crrev.com/3ba0480e95aac446e3a0f54bdaef9168469f0749 Cr-Commit-Position: refs/heads/master@{#293999}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M content/renderer/media/audio_renderer_mixer_manager.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
DaleCurtis
6 years, 3 months ago (2014-09-05 22:51:24 UTC) #2
scherkus (not reviewing)
lgtm w/ nit https://codereview.chromium.org/517793003/diff/1/content/renderer/media/audio_renderer_mixer_manager.cc File content/renderer/media/audio_renderer_mixer_manager.cc (right): https://codereview.chromium.org/517793003/diff/1/content/renderer/media/audio_renderer_mixer_manager.cc#newcode24 content/renderer/media/audio_renderer_mixer_manager.cc:24: // ARM owners may be garbage ...
6 years, 3 months ago (2014-09-05 23:04:59 UTC) #3
DaleCurtis
+jamesr for content/renderer/render_thread_impl.cc https://codereview.chromium.org/517793003/diff/1/content/renderer/media/audio_renderer_mixer_manager.cc File content/renderer/media/audio_renderer_mixer_manager.cc (right): https://codereview.chromium.org/517793003/diff/1/content/renderer/media/audio_renderer_mixer_manager.cc#newcode24 content/renderer/media/audio_renderer_mixer_manager.cc:24: // ARM owners may be garbage ...
6 years, 3 months ago (2014-09-05 23:09:35 UTC) #6
jamesr
lgtm
6 years, 3 months ago (2014-09-09 00:56:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/517793003/40001
6 years, 3 months ago (2014-09-09 16:53:36 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/6887)
6 years, 3 months ago (2014-09-09 19:09:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/517793003/40001
6 years, 3 months ago (2014-09-09 19:16:14 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:40001) as 3fde9654ec2985e902d3db830964c328aa8f7d02
6 years, 3 months ago (2014-09-09 20:29:03 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:55:17 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3ba0480e95aac446e3a0f54bdaef9168469f0749
Cr-Commit-Position: refs/heads/master@{#293999}

Powered by Google App Engine
This is Rietveld 408576698