Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2702)

Unified Diff: content/renderer/media/audio_renderer_mixer_manager.cc

Issue 517793003: Reorder AudioMessageFilter shutdown. Remove spammy DCHECK. (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/render_thread_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/audio_renderer_mixer_manager.cc
diff --git a/content/renderer/media/audio_renderer_mixer_manager.cc b/content/renderer/media/audio_renderer_mixer_manager.cc
index b2d743e0b96e6dd240ea4a7fa15c77b2ae3a049b..901807bad19e865da43a8d860cbb43a56ac0c015 100644
--- a/content/renderer/media/audio_renderer_mixer_manager.cc
+++ b/content/renderer/media/audio_renderer_mixer_manager.cc
@@ -21,7 +21,9 @@ AudioRendererMixerManager::AudioRendererMixerManager(
}
AudioRendererMixerManager::~AudioRendererMixerManager() {
- DCHECK(mixers_.empty());
+ // References to AudioRendererMixers may be owned by garbage collected
+ // objects. During process shutdown they may be leaked, so, transitively,
+ // |mixers_| may leak (i.e., may be non-empty at this time) as well.
}
media::AudioRendererMixerInput* AudioRendererMixerManager::CreateInput(
« no previous file with comments | « no previous file | content/renderer/render_thread_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698