Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 517663003: Expose drawTextBlob to devices. (Closed)

Created:
6 years, 3 months ago by f(malita)
Modified:
6 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Expose drawTextBlob to devices. Instead of unrolling blobs in SkCanvas, perform the equivalent ops in SkBaseDevice. This depends on https://codereview.chromium.org/511783005/. R=reed@google.com,robertphillips@google.com,jvanverth@google.com Committed: https://skia.googlesource.com/skia/+/aa1b9120463fc69be7a5545eb83e6fbe6955a424

Patch Set 1 #

Patch Set 2 : minor formatting tweak #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -36 lines) Patch
M include/core/SkDevice.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/core/SkTextBlob.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +5 lines, -35 lines 0 comments Download
M src/core/SkDevice.cpp View 1 2 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
f(malita)
6 years, 3 months ago (2014-08-28 18:43:11 UTC) #1
f(malita)
fmalita@chromium.org changed reviewers: + bsalomon@google.com
6 years, 3 months ago (2014-08-28 18:43:24 UTC) #2
reed1
cpu-side lgtm
6 years, 3 months ago (2014-08-28 18:48:01 UTC) #3
robertphillips
lgtm
6 years, 3 months ago (2014-08-28 19:34:53 UTC) #4
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 3 months ago (2014-08-28 21:16:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/517663003/40001
6 years, 3 months ago (2014-08-28 21:17:00 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-08-28 21:32:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as aa1b9120463fc69be7a5545eb83e6fbe6955a424

Powered by Google App Engine
This is Rietveld 408576698