Source/core/html/HTMLMediaElement.h - Issue 517593003: Allow HTMLMediaElement.currentTime to be set before the transition to HAVE_METADATA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 517593003: Allow HTMLMediaElement.currentTime to be set before the transition to HAVE_METADATA (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fast-Forward to origin/master and rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/media/video-seek-no-src.html ('K') | « LayoutTests/media/video-seek-no-src-expected.txt ('k') | Source/core/html/HTMLMediaElement.cpp » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLMediaElement.h

diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h

index 7c0acbcd7817fab0558cacc6cfd06f04c3344f78..91f5f639b11136fd2590b40baf584ff8112b68ba 100644

--- a/Source/core/html/HTMLMediaElement.h

+++ b/Source/core/html/HTMLMediaElement.h

@@ -376,7 +376,7 @@ private:

void startProgressEventTimer();

void stopPeriodicTimers();

- void seek(double time, ExceptionState&);

+ void seek(double time);

void finishSeek();

void checkIfSeekNeeded();

void addPlayedRange(double start, double end);

@@ -509,6 +509,9 @@ private:

// The last time a timeupdate event was sent in movie time.

double m_lastTimeUpdateEventMovieTime;

+ // The default playback start position.

+ double m_defaultPlaybackStartPosition;

// Loading state.

enum LoadState { WaitingForSource, LoadingFromSrcAttr, LoadingFromSourceElement };

LoadState m_loadState;