LayoutTests/media/video-seek-no-src.html - Issue 517593003: Allow HTMLMediaElement.currentTime to be set before the transition to HAVE_METADATA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/media/video-seek-no-src.html

Issue 517593003: Allow HTMLMediaElement.currentTime to be set before the transition to HAVE_METADATA (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fast-Forward to origin/master and rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/media/video-currentTime-before-have-metadata.html ('K') | « LayoutTests/media/video-currentTime-before-have-metadata-expected.txt ('k') | LayoutTests/media/video-seek-no-src-exception.html » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/media/video-seek-no-src.html

diff --git a/LayoutTests/media/video-seek-no-src-exception.html b/LayoutTests/media/video-seek-no-src.html

similarity index 55%

rename from LayoutTests/media/video-seek-no-src-exception.html

rename to LayoutTests/media/video-seek-no-src.html

index 4eccf912728c247296c09c31fdc2788ef9d4ede3..1a2f759cf516136b1e0ac622b8bbda4eb234828a 100644

--- a/LayoutTests/media/video-seek-no-src-exception.html

+++ b/LayoutTests/media/video-seek-no-src.html

@@ -2,16 +2,17 @@

<body>

- <p>Test that seeking video with no 'src' attribute throws an INVALID_STATE_ERR exception.</p>

+ <p>Test that seeking video with no 'src' attribute sets default playback start position to that time.</p>

testExpected("video.networkState", HTMLMediaElement.NETWORK_EMPTY);

testExpected("video.readyState", HTMLMediaElement.HAVE_NOTHING);

- testDOMException("video.currentTime = 1.1", "DOMException.INVALID_STATE_ERR");

- setTimeout(endTest, 200)

+ video.currentTime = 1.1;

+ testExpected("video.currentTime", 1.1);

+ setTimeout(endTest(), 200);

philipj_slow 2014/09/10 09:57:05 I think the timeout isn't needed, there's nothing

amogh.bihani 2014/09/10 11:18:33 Done.

</script>

</body>

</html>