Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 517543002: [ServiceWorker] Set blob_size of ServiceWorkerFetchRequest as kuint64max when it is unknown. (Closed)

Created:
6 years, 3 months ago by horo
Modified:
6 years, 3 months ago
Reviewers:
michaeln
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] Set blob_size of ServiceWorkerFetchRequest as kuint64max when it is unknown. This patch and https://codereview.chromium.org/514113003 will fix the wrong size of blob which can be get by calling FetchEvent.request.body.asBody() of the fetch event which body includes a file item. BUG=402387 Committed: https://crrev.com/792dcd9ba6050f1dce72f9a7e1961e0f0ceabc2c Cr-Commit-Position: refs/heads/master@{#292566}

Patch Set 1 #

Total comments: 4

Patch Set 2 : add blank lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M content/browser/service_worker/service_worker_url_request_job.cc View 1 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
horo
horo@chromium.org changed reviewers: + michaeln@chromium.org
6 years, 3 months ago (2014-08-28 12:02:25 UTC) #1
horo
michaeln@ Could you please review?
6 years, 3 months ago (2014-08-28 12:02:25 UTC) #2
michaeln
lgtm https://codereview.chromium.org/517543002/diff/1/content/browser/service_worker/service_worker_url_request_job.cc File content/browser/service_worker/service_worker_url_request_job.cc (right): https://codereview.chromium.org/517543002/diff/1/content/browser/service_worker/service_worker_url_request_job.cc#newcode270 content/browser/service_worker/service_worker_url_request_job.cc:270: return false; nit: maybe a blank line here ...
6 years, 3 months ago (2014-08-28 22:46:35 UTC) #3
horo
Thank you! https://codereview.chromium.org/517543002/diff/1/content/browser/service_worker/service_worker_url_request_job.cc File content/browser/service_worker/service_worker_url_request_job.cc (right): https://codereview.chromium.org/517543002/diff/1/content/browser/service_worker/service_worker_url_request_job.cc#newcode270 content/browser/service_worker/service_worker_url_request_job.cc:270: return false; On 2014/08/28 22:46:34, michaeln wrote: ...
6 years, 3 months ago (2014-08-29 01:13:04 UTC) #4
horo
The CQ bit was checked by horo@chromium.org
6 years, 3 months ago (2014-08-29 02:26:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/517543002/20001
6 years, 3 months ago (2014-08-29 02:27:01 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 66febf39d3527bbee0de1a3f9daeb27c3a1e9f5d
6 years, 3 months ago (2014-08-29 03:43:17 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:06:05 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/792dcd9ba6050f1dce72f9a7e1961e0f0ceabc2c
Cr-Commit-Position: refs/heads/master@{#292566}

Powered by Google App Engine
This is Rietveld 408576698